Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOMERGE: Add bare-minimum Session API from proposal draft #1065

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

davidozog
Copy link
Member

This is an example of bare-minimum support for the OpenSHMEM Sessions proposal (openshmem-org/specification#493). It's a work-in-progress, and we might prefer to put it in shmemx, depending on committee feedback and the spec release timeline.

#define SHMEM_SESSION_OP_AMO (1l<<3)
#define SHMEM_SESSION_OP_AMO_FETCH (1l<<4)
#define SHMEM_SESSION_CHAIN (1l<<5)
#define SHMEM_SESSION_UNIFORM_AMO (1l<<6)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we are not using _OP_ for the last two? No issue with the naming, I just want to understand if there is a reason.

/* Session Routines */
SHMEM_FUNCTION_ATTRIBUTES void SHPRE()shmem_session_start(long options, shmem_ctx_t ctx);
SHMEM_FUNCTION_ATTRIBUTES void SHPRE()shmem_session_stop(shmem_ctx_t ctx);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have to move them to shmemx later.

Copy link
Collaborator

@wrrobin wrrobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidozog davidozog force-pushed the wip/sessions branch 2 times, most recently from eba3fbd to 781d881 Compare April 26, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants