-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced manifest refresh #803
Conversation
added 'DND' as few changes are pending at Job end and @san7ket is working on that now. |
command = ('curl -sk -X DELETE -H "Authorization:Basic {0}"' | ||
' "{1}/subscription/consumers/{2}/entitlements"').format( | ||
base64string.decode('utf-8'), url, consumer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use python requests
module for this?
it allows you to parse the response natively
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was followed from existing one :) : https://github.com/SatelliteQE/automation-tools/blob/master/automation_tools/__init__.py#L3167
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, i realized. I'm just thinking whether it wouldn't be better to use requests straight away
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea and would handle here #807 if that is fine with you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rplevka ping :)
d5c15b2
to
c7c05ab
Compare
c7c05ab
to
e445e67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have my ACK, though pending @rplevka comments.
The sequence of the merge should be, If we miss any Job fails
- MR in gitlab
- Automation Tools PR Enhanced manifest refresh #803
- robottelo-ci PR Manifest downloader jobs moves away from environment variables robottelo-ci#1633
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. ACK
Can we merge this and depended PR if no pending on these ? |
@vijay8451 MR is merged, pending on SatelliteQE/robottelo-ci#1633 I will try to get some review today. If it still pending untill EOD , I will merge and do a test run. |
This PR contains:
/satellite6-manifest-downloader/25