Add contextual awareness to host creation #208
Conversation
This change fixes an issue we're seeing where host entries, missing a hostname and ip, are being reconstructed for checkin. While that shouldn't be an issue during checkin, it would be if used for other purposes. With that in mind, this adds a check to see if the host is being reconstructed. If so, then it will just debug log instead of raising an error.
Some inventory syncs take a long time to complete. This change adds in a progress bar so users know there is actual progress and have an estimated completion time.
We're seeing some strang behavior in CI. These are attempts to solve them and/or get more information about what's going on.
|
What's the best way to test this? |
|
@Griffin-Sullivan there are a few things in here, but the initial one would be to checkout a host from AAP, null out the hostname and IP (edit the inventory manually), then check it back in. |
|
It seems like the checkin is happening just as it normally does. Is that what we want? I'll try again on current latest to see if I get a failure. |
There was a problem hiding this comment.
From what I gathered, before checking out this PR I ran a checkout, broker sync, change hostname and ip to null, and then check in. That returns the following error: [ERROR 230501 14:28:38] BrokerError: 'str' object has no attribute 'hostname'. Based off the description I don't know if this is exactly the issue we are trying to fix here, but after running the same steps with this PR installed, I do not get the error.
This change fixes an issue we're seeing where host entries, missing a hostname and ip, are being reconstructed for checkin. While that shouldn't be an issue during checkin, it would be if used for other purposes.
With that in mind, this adds a check to see if the host is being reconstructed. If so, then it will just debug log instead of raising an error.
Add in some new workarounds and log statements
We're seeing some strange behavior in CI. These are attempts to solve them
and/or get more information about what's going on.