Turn Host kwargs into object's attributes every time

[ogajduse]

Let's have the following host

class IPAHost(Host):
    def __init__(self, sat_obj, **kwargs):
        self.satellite = sat_obj
        kwargs['hostname'] = kwargs.get('hostname', settings.ipa.hostname)
        # Allow the class to be constructed from kwargs
        kwargs['from_dict'] = True
        kwargs.update(
            {
                'base_dn': settings.ipa.basedn,
                'disabled_user_ipa': settings.ipa.disabled_ipa_user,
            }
        )
        super().__init__(**kwargs)

Then the following code snippet

sat = Host('foo.bar')
ipahost = IPAHost(sat)
ipahost.hostname

will fail with AttributeError: 'IPAHost' object has no attribute 'hostname'

The Host __init__ stores the hostname and the name in args, not in kwargs. So we need to set name and hostname directly regardless of what from_dict is set to.

Ref: SatelliteQE/robottelo#11445
This is most likely the first host that is using from_dict. 😏

[ogajduse]

Another approach I can think of is to remove the from_dict logic and update __dict__ every time.

[JacobCallahan]

I like your last comment. Additionally, now that hostname and name aren't technically required. We can remove them as named arguments and just take it all in as kwargs. If we go that route though, it would be good to add a docstring telling people which combination of arguments are required.

[Griffin-Sullivan]

Should I review this version or are we changing the PR? @ogajduse

[ogajduse]

@Griffin-Sullivan @JacobCallahan Implemented.
Feel free to review it now.

[Griffin-Sullivan]

Ran some functional tests and used ipython to make sure host creation works with hostname and IP and doesn't work when missing either. I also verified that changing the hostname and IP to null before checkin doesn't throw an error once the checkin completes.