Add manual filtering of potential inventory searches #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're currently seeing an issue with awx where it's returning multiple possible matches based on substring matches. This is creating false ambiguous matches. This change adds a manual filter to the search results to ensure that we only return exact matches, or at least do a bit better.
bherrin3
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Current 0.4.0 Broker
(broker) ➜ broker git:(master) ✗ broker checkout --workflow deploy-rhel --tower_inventory osp-rhos01-satellite-subset-inventory-name
[INFO 230928 10:48:49] Using provider AnsibleTower to checkout
[INFO 230928 10:48:49] Using token authentication
[ERROR 230928 10:48:50] ProviderError: AnsibleTower encountered the following error: Ambigious AnsibleTower inventory name osp-rhos01-satellite-subset-inventory-name
[ERROR 230928 10:48:50] BrokerError: Error during checkout from Broker(host_classes={'host': <class 'broker.hosts.Host'>})
(broker) ➜ broker git:(master) ✗
(broker) ➜ broker git:(master) ✗ pip freeze
awxkit==21.7.0
broker==0.4.0
certifi==2022.9.24
charset-normalizer==2.1.1
click==8.1.3
dynaconf==3.1.11
idna==3.4
logzero==1.7.0
PyYAML==6.0
requests==2.28.1
ssh2-python==1.0.0
urllib3==1.26.12
Current PR broker, same broker_settings.yml file
(broker-249) ➜ broker git:(master) broker checkout --workflow deploy-rhel --tower_inventory osp-rhos01-satellite-subset-inventory-name
[INFO 230928 10:47:56] Using provider AnsibleTower to checkout
[INFO 230928 10:47:56] Using token authentication
[INFO 230928 10:47:57] Using tower inventory: osp-rhos01-satellite-subset-inventory-name
[INFO 230928 10:47:58] Waiting for job:
API: https://ip-10-0-167-235.rhos-01.prod.psi.rdu2.redhat.com/api/v2/workflow_jobs/28/
UI: https://ip-10-0-167-235.rhos-01.prod.psi.rdu2.redhat.com/#/jobs/workflow/28/output
...
(broker-249) ➜ broker git:(master) pip freeze
awxkit==23.2.0
broker @ file:///Users/bherring/git/review/broker_update/broker
certifi==2023.7.22
charset-normalizer==3.2.0
click==8.1.7
dynaconf==3.2.3
idna==3.4
logzero==1.7.0
PyYAML==6.0.1
requests==2.31.0
ssh2-python==1.0.0
urllib3==2.0.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently seeing an issue with awx where it's returning multiple possible matches based on substring matches. This is creating false ambiguous matches. This change adds a manual filter to the search results to ensure that we only return exact matches, or at least do a bit better.