Add IPv6 support #260
Merged
Add IPv6 support #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyejare
approved these changes
Feb 1, 2024
Comment on lines
+45
to
+46
| ipv6 (bool): Whether or not to use IPv6. Defaults to False. | ||
| ipv4_fallback (bool): Whether or not to fallback to IPv4 if IPv6 fails. Defaults to True. |
There was a problem hiding this comment.
Should we keep the type format in docstrings same across ?
There was a problem hiding this comment.
yeah, i can make that update
|
@JacobCallahan Verified the combination of IPV6_HOST set to True and FALLBACK to False , it worked as expected! |
This change is mostly focused around the addition of IPv6 connection functionality to Broker's Host Sessions. Included are options for an ipv6 connection preference with an opt-out ipv6 connection fallback. These have also been added to the settings file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is mostly focused around the addition of IPv6 connection functionality to Broker's Host Sessions.
Included are options for an ipv6 connection preference with an opt-out ipv6 connection fallback.
These have also been added to the settings file.