truncate existing files on sftp write #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogajduse
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
ACK, good find, @rmynar.
Only one thing comes to my mind...
@JacobCallahan Would you like to preserve the current behavior by allowing the user to decide whether to truncate the file?
JacobCallahan
approved these changes
Feb 15, 2024
|
@ogajduse that's a good suggestion to keep in mind for the future if needed, but would complicate the current design a bit. Let's hold off on that for now and revisit if issues arise from this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our use case we create a backup of a config file, modify the config file (adding characters), perform testing and restore the original config from backup. We use sftp to read and write the backup. However the restore (sftp_write) ends with damaged config file. Damaged file consists of original content and few characters remained from modified file.
Adding flag LIBSSH2_FXF_TRUNC should solve the problem by truncating existing files.
see: https://libssh2.org/libssh2_sftp_open_ex.html