Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated usage of pkg_resources in favor of importlib.metadata. #286

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Remove deprecated usage of pkg_resources in favor of importlib.metadata. #286

merged 1 commit into from
Apr 16, 2024

Conversation

tpapaioa
Copy link
Collaborator

Removes the deprecated usage of the pkg_resources module.

#283

This change affects only the internals of the broker --version command. The command output is unaffected. Example output with this change:

$ broker --version
Version: 0.4.10.dev2+g6db4e5b
Broker Directory: /home/tpapaioa/.broker
Settings File: /home/tpapaioa/.broker/broker_settings.yaml
Inventory File: /home/tpapaioa/.broker/inventory.yaml
Log File: /home/tpapaioa/.broker/logs/broker.log

@JacobCallahan JacobCallahan changed the base branch from master to 0.5 April 16, 2024 15:59
@JacobCallahan JacobCallahan merged commit f91b4eb into SatelliteQE:0.5 Apr 16, 2024
4 checks passed
@tpapaioa tpapaioa deleted the update_version_check branch April 16, 2024 16:06
@ogajduse ogajduse linked an issue Apr 16, 2024 that may be closed by this pull request
pkg_resources module is deprecated and should be replaced with importlib #283
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobCallahan JacobCallahan JacobCallahan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkg_resources module is deprecated and should be replaced with importlib
2 participants
@tpapaioa @JacobCallahan