Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RHCloud.advisor_engine_config API #1276

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Add RHCloud.advisor_engine_config API #1276

merged 1 commit into from
Feb 18, 2025
+10 −1

Conversation

tpapaioa
Copy link
Contributor

@tpapaioa tpapaioa commented Feb 11, 2025 •
edited
Loading

Description of changes

Add advisor_engine_config method to the RHCloud entity, to call and return the response from the new API method introduced in theforeman/foreman_rh_cloud#932

Upstream API documentation, plugin, or feature links

theforeman/foreman_rh_cloud#932

Needed for robottelo tests:

SAT-30174
SatelliteQE/robottelo#17342

Functional demonstration

Example:

>>> from robottelo.hosts import Satellite
>>> sat = Satellite(hostname='XXX')
>>> sat.api.RHCloud().advisor_engine_config()
{'use_local_advisor_engine': False}
Additional Information

@tpapaioa tpapaioa added the No-CherryPick PR doesnt need CherryPick to previous branches label Feb 11, 2025
@tpapaioa tpapaioa self-assigned this Feb 11, 2025
@tpapaioa tpapaioa mentioned this pull request Feb 11, 2025
Draft
@tpapaioa tpapaioa force-pushed the add_rh_cloud_advisor_engine_config branch from 2b9eaa3 to c4b1bbf Compare February 15, 2025 16:00
@tpapaioa tpapaioa marked this pull request as ready for review February 15, 2025 16:04
ColeHiggins2
ColeHiggins2 approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@ColeHiggins2 ColeHiggins2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ogajduse ogajduse merged commit 75a58c5 into SatelliteQE:master Feb 18, 2025
14 checks passed
@tpapaioa tpapaioa deleted the add_rh_cloud_advisor_engine_config branch February 18, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogajduse ogajduse ogajduse approved these changes

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

Assignees

@tpapaioa tpapaioa

Labels
No-CherryPick PR doesnt need CherryPick to previous branches Stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tpapaioa @ogajduse @ColeHiggins2