Enforce the Dynaconf validaton

SatelliteQE · Jun 17, 2024 · 4eeef2e · 4eeef2e
1 parent 90ffb9b
commit 4eeef2e
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 45 deletions.
diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
@@ -9,6 +9,7 @@ env:
     PYCURL_SSL_LIBRARY: openssl
     ROBOTTELO_BUGZILLA__API_KEY: ${{ secrets.BUGZILLA_KEY }}
     ROBOTTELO_JIRA__API_KEY: ${{ secrets.JIRA_KEY }}
+    ROBOTTELO_ROBOTTELO__SETTINGS__SKIP_VALIDATION: true
 
 jobs:
   codechecks:

diff --git a/conf/certs.yaml.template b/conf/certs.yaml.template
diff --git a/conf/clients.yaml.template b/conf/clients.yaml.template
diff --git a/conf/discovery.yaml.template b/conf/discovery.yaml.template
diff --git a/conf/distro.yaml.template b/conf/distro.yaml.template
diff --git a/conf/robottelo.yaml.template b/conf/robottelo.yaml.template
@@ -21,3 +21,4 @@ ROBOTTELO:
   # Dynaconf and Dynaconf hooks related options
   SETTINGS:
     GET_FRESH: true
+    SKIP_VALIDATION: false
diff --git a/robottelo/config/__init__.py b/robottelo/config/__init__.py
@@ -40,10 +40,12 @@ def get_settings():
         try:
             settings.validators.validate()
         except ValidationError as err:
-            logger.warning(
-                f'Dynaconf validation failed, continuing for the sake of unit tests\n{err}'
-            )
-
+            if settings.robottelo.settings.get('skip_validation'):
+                logger.warning(
+                    f'Dynaconf validation failed, continuing for the sake of unit tests\n{err}'
+                )
+            else:
+                raise err
         return settings
 
 

diff --git a/robottelo/config/validators.py b/robottelo/config/validators.py
@@ -85,16 +85,6 @@
         Validator('capsule.deploy_workflows.os', must_exist=True),
         Validator('capsule.deploy_arguments', must_exist=True, is_type_of=dict, default={}),
     ],
-    certs=[
-        Validator(
-            'certs.cert_file',
-            'certs.key_file',
-            'certs.req_file',
-            'certs.ca_bundle_file',
-            must_exist=True,
-        )
-    ],
-    clients=[Validator('clients.provisioning_server')],
     libvirt=[
         Validator('libvirt.libvirt_hostname', must_exist=True),
         Validator('libvirt.libvirt_image_dir', default='/var/lib/libvirt/images'),
@@ -116,17 +106,6 @@
             must_exist=True,
         ),
     ],
-    discovery=[Validator('discovery.discovery_iso', must_exist=True)],
-    distro=[
-        Validator(
-            'distro.image_el7',
-            'distro.image_el6',
-            'distro.image_el8',
-            'distro.image_sles11',
-            'distro.image_sles12',
-            must_exist=True,
-        )
-    ],
     docker=[
         Validator(
             'docker.external_registry_1',
@@ -335,6 +314,9 @@
         Validator('remotedb.ssl', default=True),
         Validator('remotedb.port', default=5432),
     ],
+    robottelo=[
+        Validator('robottelo.settings.skip_validation', is_type_of=bool, default=False),
+    ],
     shared_function=[
         Validator('shared_function.storage', is_in=('file', 'redis'), default='file'),
         Validator('shared_function.share_timeout', lte=86400, default=86400),