[6.15.z] Fix validation: validate IPv6 proxy URL only when IS_IPV6 is set to True #15423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Satellite-QE
added
6.15.z
lpramuk
approved these changes
Jun 17, 2024
lpramuk
deleted the
cherry-pick-6.15.z-90ffb9b671af4a9ae74fedb4f2468df05f4d024f
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #15413
Problem Statement
Using latest robottelo, including the IPv6-related changes, I am running into
This error is caused by a validator that enforces string type, but it is setting the value to None itself. :meow_shrugs:
Solution
Utilize conditional validation - validate the IPv6 proxy URL setting only when IS_IPV6 is set to True
https://www.dynaconf.com/validation/#conditional-validation
Related Issues
This should be fixed before #15289 goes in