-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TFA fix for discovery plugin #15783
TFA fix for discovery plugin #15783
Conversation
trigger: test-robottelo |
PRT Result
|
e9f0a14
to
f90584d
Compare
5413fe0
to
276ddd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, pending airgun merge
@@ -121,7 +121,7 @@ def test_positive_crud_with_non_admin_user( | |||
|
|||
session.discoveryrule.delete(new_rule_name) | |||
dr_val = session.discoveryrule.read_all() | |||
assert new_rule_name not in [rule['Name'] for rule in dr_val] | |||
assert new_rule_name not in dr_val |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amolpati30 you need to fix/update the rest of the tests too. There are 4 more places in the code where this change is needed. For example,
dr_val = session.discoveryrule.read_all() |
7fcc48a
to
590e55a
Compare
"trigger": "test-robottelo" |
PRT Result
|
@@ -154,7 +154,7 @@ def test_negative_delete_rule_with_non_admin_user( | |||
with pytest.raises(ValueError): # noqa: PT011 - TODO Adarsh determine better exception | |||
session.discoveryrule.delete(dr.name) | |||
dr_val = session.discoveryrule.read_all() | |||
assert dr.name in [rule['Name'] for rule in dr_val] | |||
assert dr.name not in dr_val |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert dr.name not in dr_val | |
assert dr.name in dr_val |
@amolpati30 You have changed the assertion here. Is this expected?
590e55a
to
066b80d
Compare
06b3ca8
to
8a3ddea
Compare
trigger: test-robottelo |
b42fd69
to
ce318fb
Compare
trigger: test-robottelo |
PRT Result
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
update in test
ce318fb
to
8bffb80
Compare
trigger: test-robottelo |
PRT Result
|
fixed in discoveryrule assertion update in test (cherry picked from commit 95906c1)
fixed in discoveryrule assertion update in test (cherry picked from commit 95906c1)
TFA fix for discovery plugin (#15783) fixed in discoveryrule assertion update in test (cherry picked from commit 95906c1) Co-authored-by: amolpati30 <[email protected]>
fixed in discoveryrule assertion update in test
The failure occurred because the code was deleting the discovery rule, and then attempting to read from the deleted table using the
read_all()
method. To resolve this issue, I added theread_after_del()
method, which reads the page message after a rule is deleted or if there are no more tables.Dependent PR: SatelliteQE/airgun#1480