Add hdm to installer's UPSTREAM_SPECIFIC_MODULES & fix comparison #15833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the right hand side it is `dict_keys() - set()` which results in a set. While you can compare dict_keys and set, the resulting diff isn't very useful because pytest doesn't diff the elements. This converts the left hand side into a set so it's comparing two sets. Technically that's also correct because for us the order doesn't matter either; it's only about the elements.
HDM is a new plugin that recently started shipping upstream, but don't ship downstream.
|
Can one of the admins verify this patch? |
|
trigger: test-robottelo |
Gauravtalreja1
added
the
No-CherryPick
JacobCallahan
approved these changes
Aug 15, 2024
jameerpathan111
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
This has two problems. First of all, HDM is a new plugin that recently started shipping upstream, but don't ship downstream.
The second problem is that the diff is hard to read. On the right hand side it is
dict_keys() - set()which results in a set. While you can comparedict_keysandset, the resulting diff isn't very useful because pytest doesn't diff the elements.Solution
For the first problem, hdm is added to installer's
UPSTREAM_SPECIFIC_MODULES.The second problem is solved by converting the left hand side into a set so it's comparing two sets. Technically that's also correct because for us the order doesn't matter either; it's only about the elements.
Related Issues
theforeman/foreman-installer@de26c75 added HDM to the upstream installer.