-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for multi-CV hosts #15871
Add tests for multi-CV hosts #15871
Conversation
7a8e313
to
f49016e
Compare
f49016e
to
6ea1762
Compare
6ea1762
to
d3e54ee
Compare
trigger: test-robottelo |
PRT Result
|
8871d61
to
a07af63
Compare
trigger: test-robottelo |
PRT Result
|
hmm these tests are passing locally, why is PRT failing.. 🤔 |
trigger: test-robottelo |
PRT Result
|
trigger: test-robottelo |
PRT Result
|
trigger: test-robottelo |
PRT Result
|
trigger: test-robottelo |
a07af63
to
17dca5e
Compare
trigger: test-robottelo |
17dca5e
to
8b77119
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion, but optional.
You can put the org, cv, and lce setup to fixtures and use them in both tests.
@pytest.fixture(scope='session')
def session_multicv_org(session_multicv_sat):
return session_multicv_sat.api.Organization().create()
@pytest.fixture(scope='session')
def session_multicv_ak(session_multicv_sat, session_multicv_org):
return session_multicv_sat.api.ActivationKey(
organization=session_multicv_org,
content_view=session_multicv_org.default_content_view.id,
environment=session_multicv_org.library.id,
).create()
@pytest.fixture(scope='session')
def session_multicv_lce(session_multicv_sat, session_multicv_org):
return session_multicv_sat.api.LifecycleEnvironment(
organization=session_multicv_org,
).create()
I am not 100% sure where to put them, but my first guess is pytest_fixtures/component/contentview.py
. @vsedmik would you choose a different file to put these in?
I think |
ce97882
to
912167d
Compare
|
912167d
to
4b97ba9
Compare
trigger: test-robottelo |
PRT Result
|
4b97ba9
to
f7a4896
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
trigger: test-robottelo |
PRT Result
|
f7a4896
to
80601ed
Compare
trigger: test-robottelo |
PRT Result
|
a12c6b6
to
c317db9
Compare
Add tests for multi-CV hosts (#15871) Co-authored-by: Jeremy Lenz <[email protected]>
Problem Statement
Test coverage for multi-CV functionality is needed
Solution
Add tests for multi-CV:
multi-CV assignment via hammer (not working yet)I moved this to another PR so I am marking this PR as ready for review.Related Issues