Add tests for multi-CV hosts

[jeremylenz]

Problem Statement

Test coverage for multi-CV functionality is needed

Solution

Add tests for multi-CV:

1. basic multi-CV registration (positive)
2. multi-CV assignment with sub-man environments & repo access
3. multi-CV assignment via hammer (not working yet) I moved this to another PR so I am marking this PR as ready for review.

Related Issues

[jeremylenz]

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k 'test_positive_multi_cv_registration or test_positive_multi_cv_host_repo_availability'

[Satellite-QE]

PRT Result

Build Number: 8006
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_positive_multi_cv_registration or test_positive_multi_cv_host_repo_availability --external-logging
Test Result : ========== 90 deselected, 125 warnings, 4 errors in 671.42s (0:11:11) ==========

[jeremylenz]

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k 'test_positive_multi_cv_registration or test_positive_multi_cv_host_repo_availability'

[Satellite-QE]

PRT Result

Build Number: 8008
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_positive_multi_cv_registration or test_positive_multi_cv_host_repo_availability --external-logging
Test Result : ========== 90 deselected, 125 warnings, 4 errors in 670.98s (0:11:10) ==========

[jeremylenz]

hmm these tests are passing locally, why is PRT failing.. 🤔

[jeremylenz]

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k 'test_positive_multi_cv_registration or test_positive_multi_cv_host_repo_availability'

[Satellite-QE]

PRT Result

Build Number: 8012
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_positive_multi_cv_registration or test_positive_multi_cv_host_repo_availability --external-logging
Test Result : ========== 90 deselected, 125 warnings, 4 errors in 682.84s (0:11:22) ==========

[sambible]

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k 'test_positive_multi_cv_registration'

[Satellite-QE]

PRT Result

Build Number: 8015
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_positive_multi_cv_registration --external-logging
Test Result : ========== 92 deselected, 99 warnings, 2 errors in 209.21s (0:03:29) ===========

[sambible]

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k 'test_positive_multi_cv_registration'

[Satellite-QE]

PRT Result

Build Number: 8017
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_positive_multi_cv_registration --external-logging
Test Result : ========== 92 deselected, 99 warnings, 2 errors in 214.29s (0:03:34) ===========

[jeremylenz]

trigger: test-robottelo
pytest: tests/foreman/api/test_ping.py -k 'test_positive_ping'

[jeremylenz]

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k 'test_positive_multi_cv_registration or test_positive_multi_cv_host_repo_availability'

[ogajduse]

Small suggestion, but optional.

You can put the org, cv, and lce setup to fixtures and use them in both tests.

@pytest.fixture(scope='session')
def session_multicv_org(session_multicv_sat):
    return session_multicv_sat.api.Organization().create()


@pytest.fixture(scope='session')
def session_multicv_ak(session_multicv_sat, session_multicv_org):
    return session_multicv_sat.api.ActivationKey(
        organization=session_multicv_org,
        content_view=session_multicv_org.default_content_view.id,
        environment=session_multicv_org.library.id,
    ).create()


@pytest.fixture(scope='session')
def session_multicv_lce(session_multicv_sat, session_multicv_org):
    return session_multicv_sat.api.LifecycleEnvironment(
        organization=session_multicv_org,
    ).create()

I am not 100% sure where to put them, but my first guess is pytest_fixtures/component/contentview.py. @vsedmik would you choose a different file to put these in?

[vsedmik]

Small suggestion, but optional.

You can put the org, cv, and lce setup to fixtures and use them in both tests.

@pytest.fixture(scope='session')
def session_multicv_org(session_multicv_sat):
    return session_multicv_sat.api.Organization().create()


@pytest.fixture(scope='session')
def session_multicv_ak(session_multicv_sat, session_multicv_org):
    return session_multicv_sat.api.ActivationKey(
        organization=session_multicv_org,
        content_view=session_multicv_org.default_content_view.id,
        environment=session_multicv_org.library.id,
    ).create()


@pytest.fixture(scope='session')
def session_multicv_lce(session_multicv_sat, session_multicv_org):
    return session_multicv_sat.api.LifecycleEnvironment(
        organization=session_multicv_org,
    ).create()

I am not 100% sure where to put them, but my first guess is pytest_fixtures/component/contentview.py. @vsedmik would you choose a different file to put these in?

I think pytest_fixtures/component/contentview.py is good location. Also I agree to define those notoriously used fixtures like that so we don't need to create the entities in every test. 👍

[jeremylenz]

1. Added fixtures for session_multicv_org, session_multicv_default_ak (I renamed that one to highlight that the AK is attached to Library/default org view), and session_multicv_lce.
2. Modified tests to use the new fixtures
3. Addressed other comments

[jeremylenz]

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k 'test_positive_multi_cv_registration or test_positive_multi_cv_host_repo_availability'

[Satellite-QE]

PRT Result

Build Number: 8131
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_positive_multi_cv_registration or test_positive_multi_cv_host_repo_availability --external-logging
Test Result : ========= 4 passed, 90 deselected, 234 warnings in 1560.57s (0:26:00) ==========

[vsedmik]

Looks great, thank you!

[vsedmik]

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k 'test_positive_multi_cv_registration or test_positive_multi_cv_host_repo_availability'

[Satellite-QE]

PRT Result

Build Number: 8133
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_positive_multi_cv_registration or test_positive_multi_cv_host_repo_availability --external-logging
Test Result : ========= 90 deselected, 126 warnings, 4 errors in 1118.98s (0:18:38) ==========

[jeremylenz]

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k 'test_positive_multi_cv_registration or test_positive_multi_cv_host_repo_availability'

[Satellite-QE]

PRT Result

Build Number: 8148
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_positive_multi_cv_registration or test_positive_multi_cv_host_repo_availability --external-logging
Test Result : ========= 4 passed, 90 deselected, 228 warnings in 1469.76s (0:24:29) ==========