-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding the support for ipv4 and ipv6 parameterization for Container and VM #15881
Merged
JacobCallahan
merged 1 commit into
SatelliteQE:master
from
omkarkhatavkar:ipv4_6_parameterization
Aug 20, 2024
Merged
adding the support for ipv4 and ipv6 parameterization for Container and VM #15881
JacobCallahan
merged 1 commit into
SatelliteQE:master
from
omkarkhatavkar:ipv4_6_parameterization
Aug 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyejare
reviewed
Aug 7, 2024
omkarkhatavkar
force-pushed
the
ipv4_6_parameterization
branch
5 times, most recently
from
August 8, 2024 11:23
061c1a7
to
9bee992
Compare
omkarkhatavkar
added
CherryPick
PR needs CherryPick to previous branches
6.13.z
Introduced in or relating directly to Satellite 6.13
6.14.z
Introduced in or relating directly to Satellite 6.14
6.15.z
Introduced in or relating directly to Satellite 6.15
labels
Aug 8, 2024
omkarkhatavkar
force-pushed
the
ipv4_6_parameterization
branch
3 times, most recently
from
August 12, 2024 12:10
56898f9
to
a9c141a
Compare
omkarkhatavkar
force-pushed
the
ipv4_6_parameterization
branch
from
August 12, 2024 14:47
a9c141a
to
cdc8c34
Compare
JacobCallahan
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
jyejare
approved these changes
Aug 14, 2024
Sanity Test Suite is passed with change including CI link to CI PR |
omkarkhatavkar
force-pushed
the
ipv4_6_parameterization
branch
from
August 16, 2024 07:25
cdc8c34
to
fcca1c7
Compare
This was referenced Aug 20, 2024
omkarkhatavkar
added a commit
to omkarkhatavkar/robottelo
that referenced
this pull request
Aug 21, 2024
5 tasks
Gauravtalreja1
pushed a commit
that referenced
this pull request
Sep 3, 2024
…ntainer and VM (#16004) adding the support for ipv4 and ipv6 parameterization for Container and VM (#15881) (cherry picked from commit ccbb5bd) Co-authored-by: Omkar Khatavkar <[email protected]>
Gauravtalreja1
pushed a commit
that referenced
this pull request
Sep 3, 2024
…ntainer and VM (#16202) adding the support for ipv4 and ipv6 parameterization for Container and VM (#15881) (cherry picked from commit ccbb5bd) Co-authored-by: Omkar Khatavkar <[email protected]>
jyejare
pushed a commit
to jyejare/robottelo
that referenced
this pull request
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.13.z
Introduced in or relating directly to Satellite 6.13
6.14.z
Introduced in or relating directly to Satellite 6.14
6.15.z
Introduced in or relating directly to Satellite 6.15
CherryPick
PR needs CherryPick to previous branches
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Currently, Content-Host-based test-cases/fixtures are not taking an input/param for network type so that the ipv6 / ipv4 satellite can connect with the ipv6 / ipv4 content host.
But, since broker and Tower support provide the param for choosing the network type, we have to alter the content host tests cases/fixtures to take the argument for the network type parameter.
Solution
As discussed in the brainstorming call on 31st July 2024, we will choose to parameterise tests to provide the network type parameter. That looks like:
@pytest.mark.network_type(['ipv4', 'ipv6'])
that as value can also take the regex very similar as rhel_ver_list / rhel_Ver_match implementation.CI PR Dependency
1439
Test Matrix
If there is no marker then it will pick the network based on the Satellite.