Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the support for ipv4 and ipv6 parameterization for Container and VM #15881

Merged

Conversation

omkarkhatavkar
Copy link
Contributor

@omkarkhatavkar omkarkhatavkar commented Aug 7, 2024

Problem Statement

Currently, Content-Host-based test-cases/fixtures are not taking an input/param for network type so that the ipv6 / ipv4 satellite can connect with the ipv6 / ipv4 content host.

But, since broker and Tower support provide the param for choosing the network type, we have to alter the content host tests cases/fixtures to take the argument for the network type parameter.

Solution

As discussed in the brainstorming call on 31st July 2024, we will choose to parameterise tests to provide the network type parameter. That looks like:

@pytest.mark.network_type(['ipv4', 'ipv6']) that as value can also take the regex very similar as rhel_ver_list / rhel_Ver_match implementation.

  • Generate tests based on the network type parametrization on the test
  • Insert the appropriate network type option for spinning the RHEL content host
  • The option insertion should be based on container and no_container
  • Generate the test cases for cross network Satellite-IPv4 - Podman IPv6 and Satellite-IPv6 - Podman IPv4
  • Have at least one test that shows the test generation works.

CI PR Dependency

1439

Test Matrix

Network Marker Satellite VM/Container Network Configuration Tests to Run Expected Result
ipv4 Yes present [rhel7-ipv4], [rhel8-ipv4], [rhel9-ipv4] Pass
ipv4 Yes present (empty list) [rhel7-ipv4], [rhel8-ipv4], [rhel9-ipv4] Pass
ipv4 Yes present (only ipv4) [rhel7-ipv4], [rhel8-ipv4], [rhel9-ipv4] Pass
ipv4 Yes present (only ipv6) [rhel7-ipv6], [rhel8-ipv6], [rhel9-ipv6] Fail
ipv4 Yes present ([ipv4, ipv6]) [rhel7-ipv6], [rhel8-ipv6], [rhel9-ipv6], [rhel7-ipv4], [rhel8-ipv4], [rhel9-ipv4] Pass/Fail
ipv6 Yes present [rhel7-ipv6], [rhel8-ipv6], [rhel9-ipv6] Pass
ipv6 Yes present (empty list) [rhel7-ipv6], [rhel8-ipv6], [rhel9-ipv6] Pass
ipv6 Yes present (only ipv4) [rhel7-ipv4], [rhel8-ipv4], [rhel9-ipv4] Fail
ipv6 Yes present (only ipv6) [rhel7-ipv6], [rhel8-ipv6], [rhel9-ipv6] Pass
ipv6 Yes present ([ipv4, ipv6]) [rhel7-ipv6], [rhel8-ipv6], [rhel9-ipv6], [rhel7-ipv4], [rhel8-ipv4], [rhel9-ipv4] Pass/Fail

If there is no marker then it will pick the network based on the Satellite.

@omkarkhatavkar omkarkhatavkar requested a review from a team as a code owner August 7, 2024 14:38
@omkarkhatavkar omkarkhatavkar marked this pull request as draft August 7, 2024 14:38
@omkarkhatavkar omkarkhatavkar force-pushed the ipv4_6_parameterization branch 5 times, most recently from 061c1a7 to 9bee992 Compare August 8, 2024 11:23
@omkarkhatavkar omkarkhatavkar added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Aug 8, 2024
@omkarkhatavkar omkarkhatavkar force-pushed the ipv4_6_parameterization branch 3 times, most recently from 56898f9 to a9c141a Compare August 12, 2024 12:10
@omkarkhatavkar omkarkhatavkar marked this pull request as ready for review August 12, 2024 12:45
Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@omkarkhatavkar
Copy link
Contributor Author

Sanity Test Suite is passed with change including CI link to CI PR

github-actions bot pushed a commit that referenced this pull request Sep 3, 2024
Gauravtalreja1 pushed a commit that referenced this pull request Sep 3, 2024
…ntainer and VM (#16004)

adding the support for ipv4 and ipv6 parameterization for Container and VM (#15881)

(cherry picked from commit ccbb5bd)

Co-authored-by: Omkar Khatavkar <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Sep 3, 2024
…ntainer and VM (#16202)

adding the support for ipv4 and ipv6 parameterization for Container and VM (#15881)

(cherry picked from commit ccbb5bd)

Co-authored-by: Omkar Khatavkar <[email protected]>
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants