Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom content for RHEL10 until SAT-29721 is resolved #17369

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use custom content for RHEL10 until SAT-29721 is resolved #17369

wants to merge 2 commits into from
+65 −53

Conversation

Gauravtalreja1
Copy link
Collaborator

Problem Statement

With RHEL10 beta repos, provisioning fails because of SAT-29721, and it will be fixed when it becomes GA

Solution

Use custom content for RHEL10 until SAT-29721 is resolved

Related Issues

@Gauravtalreja1 Gauravtalreja1 added the No-CherryPick PR doesnt need CherryPick to previous branches label Jan 17, 2025
@Gauravtalreja1 Gauravtalreja1 self-assigned this Jan 17, 2025
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner January 17, 2025 11:12
@Gauravtalreja1 Gauravtalreja1 changed the title Use custom Content for RHEL10 until SAT-29721 is resolved Use custom content for RHEL10 until SAT-29721 is resolved Jan 17, 2025
@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jan 17, 2025
@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning[rhel10-ipv4-uefi]
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9925
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning[rhel10-ipv4-uefi] --external-logging --include-onprem-provisioning
Test Result : ================== 13 warnings, 1 error in 1373.50s (0:22:53) ==================

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioning.py -k test_rhel_pxe_provisioning_secureboot_enabled
provisioning: true
env:
     BROKER_SSH__BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9930
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py -k test_rhel_pxe_provisioning_secureboot_enabled --external-logging --include-onprem-provisioning
Test Result : ========= 33 deselected, 402 warnings, 4 errors in 2105.91s (0:35:05) ==========

@Gauravtalreja1 Gauravtalreja1 force-pushed the use-internal-el10 branch 2 times, most recently from 57c113b to e59c6de Compare February 4, 2025 12:47
@shweta83
Copy link
Contributor

shweta83 commented Feb 4, 2025

Can you please rebase the PR and run PRT. This should work with latest beta repos.

@Gauravtalreja1 Gauravtalreja1 force-pushed the use-internal-el10 branch 2 times, most recently from 17b6edd to 272f48a Compare February 12, 2025 20:54
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Feb 12, 2025
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Feb 12, 2025
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Feb 12, 2025
@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioning.py -k test_rhel_pxe_provisioning_secureboot_enabled
provisioning: true
env:
     BROKER_SSH__BACKEND: hussh

@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Feb 13, 2025
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10160
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py -k test_rhel_pxe_provisioning_secureboot_enabled --external-logging --include-onprem-provisioning
Test Result : ===== 3 passed, 33 deselected, 754 warnings, 1 error in 4888.92s (1:21:28) =====

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning[rhel10-ipv4-uefi]
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10168
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning[rhel10-ipv4-uefi] --external-logging --include-onprem-provisioning
Test Result : ================= 1 failed, 17 warnings in 3112.67s (0:51:52) ==================

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning[rhel10-ipv4-uefi]
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10180
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning[rhel10-ipv4-uefi] --external-logging --include-onprem-provisioning
Test Result : ================== 10 warnings, 1 error in 938.47s (0:15:38) ===================

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning[rhel10-ipv4-uefi]
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10184
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning[rhel10-ipv4-uefi] --external-logging --include-onprem-provisioning
Test Result : ================= 1 failed, 17 warnings in 2940.21s (0:49:00) ==================

@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner February 14, 2025 17:31
@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning[rhel10-ipv4-uefi]
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10185
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning[rhel10-ipv4-uefi] --external-logging --include-onprem-provisioning
Test Result : ================= 1 failed, 17 warnings in 2553.51s (0:42:33) ==================

@Gauravtalreja1
Copy link
Collaborator Author

PRT passed with Jenkins MR of satellite-jenkins MR#1613

jyejare
jyejare reviewed Feb 18, 2025
View reviewed changes
pytest_fixtures/component/provision_pxe.py
@@ -105,7 +118,7 @@ def module_provisioning_rhel_content(
rhel_xy = Version(
constants.REPOS['kickstart'][f'rhel{rhel_ver}']['version']
if rhel_ver == 7
else constants.REPOS['kickstart'][f'rhel{rhel_ver}_bos_beta']['version']
else '10.1' # EL10 pre-release version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hardcoding 10.1, keep it as constant and use the constant here. Good coding practice.

jyejare
jyejare approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a good coding practice suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyejare jyejare jyejare approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gauravtalreja1 @Satellite-QE @shweta83 @jyejare