Update provisioning tests for IPv6 provisoning #17479
Merged
+107
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamsg199
added
No-CherryPick
shubhamsg199
force-pushed
the
Update_provisioning_tests_for_IPv6_provisoning
branch
9 times, most recently
from
0a6f954 to
a2acf2b
Compare
shubhamsg199
force-pushed
the
Update_provisioning_tests_for_IPv6_provisoning
branch
11 times, most recently
from
8f62dae to
57923bd
Compare
Comment on lines
235
to
236
| if pxe_loader.vm_firmware == 'bios': | ||
| pytest.skip('BIOS is not supported with IPv6') |
There was a problem hiding this comment.
Why skipping here explicitely, when we're skipping it in the test?
There was a problem hiding this comment.
Since we are skipping bios for IPv6, provisioning host being the function scoped fixture I don't want the host to be created unnecessarily for bios as it would run teardown as well which is a waste of execution time for us. I missed the IPv6 condition here which I will update
shubhamsg199
force-pushed
the
Update_provisioning_tests_for_IPv6_provisoning
branch
4 times, most recently
from
65cbcbf to
99afb6a
Compare
shubhamsg199
force-pushed
the
Update_provisioning_tests_for_IPv6_provisoning
branch
3 times, most recently
from
d7f9410 to
f4121da
Compare
shubhamsg199
force-pushed
the
Update_provisioning_tests_for_IPv6_provisoning
branch
2 times, most recently
from
8810ae9 to
b7e7202
Compare
Signed-off-by: Shubham Ganar <[email protected]>
shubhamsg199
force-pushed
the
Update_provisioning_tests_for_IPv6_provisoning
branch
from
b7e7202 to
f2954a4
Compare
Gauravtalreja1
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Provisioning tests are not updated to run on IPv6 satellite
Solution
Update the tests to run on IPv6 satellite
Related Issues