Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test case for flatpak CV scoping #17576

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Feb 12, 2025

Problem Statement

Satellite implements second endpoint for flatpak registry index which is org/CV scoped, while the default pulpcore endpoint is system-wide. We already have test cases for the pulpcore system-wide EP, but we need to test the CV scoped one too. It will probably become the default users would want to use.

Solution

This PR add an E2E test case for that CV scoped endpoint.

Related Issues

https://issues.redhat.com/browse/SAT-28677

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_flatpak.py -k test_sync_consume_flatpak_repo_via_cv
Katello:
  katello: 11300

@vsedmik vsedmik added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Feb 12, 2025
@vsedmik vsedmik self-assigned this Feb 12, 2025
@vsedmik vsedmik requested review from a team as code owners February 12, 2025 14:48
@vsedmik
Copy link
Contributor Author

vsedmik commented Feb 12, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_flatpak.py -k test_sync_consume_flatpak_repo_via_cv
Katello:
  katello: 11300

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10153
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_flatpak.py -k test_sync_consume_flatpak_repo_via_cv --external-logging
Test Result : ========== 1 passed, 6 deselected, 19 warnings in 1780.09s (0:29:40) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 12, 2025
Copy link
Contributor

@synkd synkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One possible typo, otherwise this looks good to me.

cv.publish()
cv.read().version[0].promote(data={'environment_ids': function_lce.id})

# 3. Create an AK assigned with one CVE only.
Copy link
Contributor

@synkd synkd Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# 3. Create an AK assigned with one CVE only.
# 3. Create an AK assigned with one CV only.

I'm guessing you meant content view here, but feel free to ignore if you did mean CVE.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying really hard not to get in the habit of using "CVE" as an abbreviation for content view environment. It may be a losing battle..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe, I got the impression that "CVE" is the new fancy way to name "particular CV version promoted to particular LCE" (and it seems so nicely short and descriptive to me)

But I can step back and update the PR with something like "CV/LCE" not to spread that nice habit further. 🥲

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsedmik I don't want to be too prescriptive here, but for me, using CVE to mean anything other than Common Vulnerabilities and Exposures in this context is confusing enough that it actually reduces code readability, because it's such an industry-standard abbreviation. It would be like coming up with a new meaning for TCP.

This is ultimately your decision, and if using CVE to mean content view environment is already an established practice, then I acknowledge that there's not much I can do about that. But if the habit is not fully established, then I would encourage both you and @jeremylenz to keep up the fight.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I'm trying not to establish it :) Usually I try to type out "content view environment" fully. Or sometimes I just use "environment," but that's not ideal either because we already have about 3 meanings for that word.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay, finally got your point with the Common Vulnerabilities and Exposures parallel. Captions updated.

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 17, 2025
@vsedmik
Copy link
Contributor Author

vsedmik commented Feb 17, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_flatpak.py -k test_sync_consume_flatpak_repo_via_cv

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10196
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_flatpak.py -k test_sync_consume_flatpak_repo_via_cv --external-logging
Test Result : ========== 1 passed, 6 deselected, 19 warnings in 1046.59s (0:17:26) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants