-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test case for flatpak CV scoping #17576
base: master
Are you sure you want to change the base?
Conversation
|
PRT Result
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One possible typo, otherwise this looks good to me.
tests/foreman/cli/test_flatpak.py
Outdated
cv.publish() | ||
cv.read().version[0].promote(data={'environment_ids': function_lce.id}) | ||
|
||
# 3. Create an AK assigned with one CVE only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# 3. Create an AK assigned with one CVE only. | |
# 3. Create an AK assigned with one CV only. |
I'm guessing you meant content view here, but feel free to ignore if you did mean CVE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying really hard not to get in the habit of using "CVE" as an abbreviation for content view environment. It may be a losing battle..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hehe, I got the impression that "CVE" is the new fancy way to name "particular CV version promoted to particular LCE" (and it seems so nicely short and descriptive to me)
But I can step back and update the PR with something like "CV/LCE" not to spread that nice habit further. 🥲
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vsedmik I don't want to be too prescriptive here, but for me, using CVE
to mean anything other than Common Vulnerabilities and Exposures
in this context is confusing enough that it actually reduces code readability, because it's such an industry-standard abbreviation. It would be like coming up with a new meaning for TCP
.
This is ultimately your decision, and if using CVE to mean content view environment
is already an established practice, then I acknowledge that there's not much I can do about that. But if the habit is not fully established, then I would encourage both you and @jeremylenz to keep up the fight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I'm trying not to establish it :) Usually I try to type out "content view environment" fully. Or sometimes I just use "environment," but that's not ideal either because we already have about 3 meanings for that word.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh okay, finally got your point with the Common Vulnerabilities and Exposures
parallel. Captions updated.
e0889d1
to
29d3d1c
Compare
|
PRT Result
|
Problem Statement
Satellite implements second endpoint for flatpak registry index which is org/CV scoped, while the default pulpcore endpoint is system-wide. We already have test cases for the pulpcore system-wide EP, but we need to test the CV scoped one too. It will probably become the default users would want to use.
Solution
This PR add an E2E test case for that CV scoped endpoint.
Related Issues
https://issues.redhat.com/browse/SAT-28677
PRT test Cases example