Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix smartclassparameter tests #17585

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix smartclassparameter tests #17585

wants to merge 1 commit into from

Conversation

shubhamsg199
Copy link
Contributor

@shubhamsg199 shubhamsg199 commented Feb 13, 2025 •
edited
Loading

Problem Statement

Smartclassparameter tests are failing in the assertion part where unnecessary spaces are present between the strings
1.

- '["Jfrhtkhjvf","4950963239","<samp>eOOzjrRZss</samp>"]'
+ '["Jfrhtkhjvf", "4950963239", "<samp>eOOzjrRZss</samp>"]'
  1. AssertionError: assert '[80, 90]' == '[80,90]'

Solution

Update the test to fix them

@shubhamsg199 shubhamsg199 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Feb 13, 2025
@shubhamsg199 shubhamsg199 self-assigned this Feb 13, 2025
@shubhamsg199 shubhamsg199 requested a review from a team as a code owner February 13, 2025 09:39
@shubhamsg199
Fix smartclassparameter tests
04b2ca4 
Signed-off-by: Shubham Ganar <[email protected]>
@shubhamsg199 shubhamsg199 force-pushed the fix_smartclassparameters_test branch from 90616aa to 04b2ca4 Compare February 13, 2025 09:44
amolpati30
amolpati30 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@amolpati30 amolpati30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"AcK. Please run the PRT on both tests. LGTM."

@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_smartclassparameter.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10162
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_smartclassparameter.py --external-logging
Test Result : ============ 3 failed, 3 passed, 127 warnings in 2256.80s (0:37:36) ============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 13, 2025
@Gauravtalreja1 Gauravtalreja1 mentioned this pull request Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amolpati30 amolpati30 amolpati30 approved these changes

Assignees

@shubhamsg199 shubhamsg199

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubhamsg199 @Satellite-QE @amolpati30