Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Added the proper logging workflow in upgrade #382

Merged

Conversation

devendra104
Copy link
Member

Copy link
Contributor

@ntkathole ntkathole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this up @devendra104, its long pending improvement.

Btw loggings need to be more precise and clear on what entity the change is happeing / going to happen. The names are better than ids and clear. If you want ids for debugging purpose keep both name and id in logging.

Also pre logging before major happenings like publish, sync is very welcome as a person get an idea on whats happening untill the success message.

upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
upgrade/helpers/tasks.py Show resolved Hide resolved
upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this up @devendra104, its long pending improvement.

Btw loggings need to be more precise and clear on what entity the change is happeing / going to happen. The names are better than ids and clear. If you want ids for debugging purpose keep both name and id in logging.

Also pre logging before major happenings like publish, sync is very welcome as a person get an idea on whats happening untill the success message.

@devendra104 devendra104 force-pushed the improvement_logging_workflow branch from aca56d3 to 395582f Compare October 30, 2019 13:37
@devendra104
Copy link
Member Author

Thanks for taking this up @devendra104, its long pending improvement.

Btw loggings need to be more precise and clear on what entity the change is happeing / going to happen. The names are better than ids and clear. If you want ids for debugging purpose keep both name and id in logging.

Also pre logging before major happenings like publish, sync is very welcome as a person get an idea on whats happening untill the success message.

Thanks @jyejare for providing the valuable comment.

Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending few nitpicks

upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
@devendra104 devendra104 force-pushed the improvement_logging_workflow branch from 395582f to c495674 Compare October 31, 2019 09:26
@devendra104 devendra104 force-pushed the improvement_logging_workflow branch from c495674 to 875f3c1 Compare October 31, 2019 12:43
@jyejare jyejare merged commit bf441f6 into SatelliteQE:master Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants