Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for neutrino clients #221

Open
wants to merge 4 commits into
base: releases/v0.7.0
Choose a base branch
from

Conversation

i5hi
Copy link

@i5hi i5hi commented Jun 3, 2021

The specfic update in this PR is at /cyphernodeconf_docker where a bitcoin_cbf property is added to the schema/config-v0.2.5.json and prompters/900_bitcoin.js to allow a user the option to set peerblockfilters=1 to templates/bitcoin/bitcoin.conf to serve compact block filters for neutrino clients.

@i5hi
Copy link
Author

i5hi commented Jun 4, 2021

This can be tested using:

docker exec -it dist_bitcoin_1 bitcoin-cli getnetworkinfo | jq -r ".localservicesnames"

[
   "NETWORK",
   "WITNESS",
   "COMPACT_FILTERS",
   "NETWORK_LIMITED"
]

@Kexkey
Copy link
Collaborator

Kexkey commented Jun 19, 2021

Thanks for the PR @vmenond ! Sorry for the delay, I was away in the last week or so.

Is the overhead of enabling peerblockfilters a big problem? Do you think it would be a good idea to just enable it by default without asking the user?

@i5hi
Copy link
Author

i5hi commented Aug 12, 2021

Hey @Kexkey! So sorry about the delay. Just saw your response to this!

There is quite a bit of networking overhead - I haven't tested it but some devs at bdk have and mentioned the overhead can be quite a bit, so might not be a good default.

Will run a few tests on this and share some exact figures.

@Kexkey
Copy link
Collaborator

Kexkey commented Sep 1, 2021

Thanks for your contribution! Can you base your PR on dev? I'd like to try this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants