Add getmininginfo call #228
Conversation
|
The getmininginfo call tested and working. The getblockhashps call don't pass the gatekeeper. Maybe related to api.properties, wip. |
|
Fixed but.. Currently getblockhashps with optional blockheight not returning the right hashps. Let wait the node is fully synced to see... |
|
Thanks and sorry for the delay, have been particularly busy lately. Did you get a chance to make it work? |
|
Yeah! No problemo, we all want to see lnurl stuff in cyphernode, keep up the good work! The getmininginfo is working perfectly, but things need to be modified for the getblockhashps. I will probably change the call name for getnetworkhashps to be consistent with bitcoincore call, and modify the returned data. I wait my cyphernode to be fully sync to test that one. I will confirm when fully tested. |
|
Fully tested and working! It's my first PR so let me know if I miss something. I'm mostly setup for testing changes now, next time I will probably do my coding and testing before pushing the PR. One thing that can be improved is adding a send_to_stats_node function in sendtobitcoinnode.sh not including wallets specifics for stats call. But since it's affect all stats call, a separate PR would be better. Let me know what you think! |
|
Updated to solve v0.8.0 conflicts. Tested and working. |
BHodl
force-pushed
the
features/getmininginfo
branch
from
d90cd3f
to
4c80f4b
Compare
|
Rebase on dev, thanks! |
BHodl
force-pushed
the
features/getmininginfo
branch
from
9742e34
to
50584d6
Compare
Let me know if I miss something. Not tested!