ci(publish): update release workflow #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pnpm seems pretty flakey, with any little change. I made a commit to master for part of this and it failed (I should have done a pr like this). I think this is fine as long as we can get the build to pass. Publish is called from github actions. |
niemyjski
reviewed
Jan 30, 2024
dysfunc
force-pushed
the
publishing
branch
2 times, most recently
from
f1e6183 to
5486d18
Compare
niemyjski
reviewed
Jan 30, 2024
|
@dysfunc I think the size plugin may be failing due to the lock file being out of date in master. I think we should try removing the ignore lock argument and merging. |
|
I reverted this before your last commit b1c9967 but I don't see it in the diff of your branch (I did this to fix the master lock file) |
|
well, that was fun. what a pain 😅 |
niemyjski
approved these changes
Jan 30, 2024
|
Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an option to reduce the amount things everywhere. This can also be moved to a publish action. All you need is your NPM secret