Skip to content

fix(lint): fix 2 CI errors — missing test import and eqeqeq violation - #544

Merged
dotunv merged 7 commits into
Savitura:mainfrom
OAKVISUALZ:fix/ci-lint-errors
Jul 28, 2026
Merged

fix(lint): fix 2 CI errors — missing test import and eqeqeq violation#544
dotunv merged 7 commits into
Savitura:mainfrom
OAKVISUALZ:fix/ci-lint-errors

Conversation

@OAKVISUALZ

@OAKVISUALZ OAKVISUALZ commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Closes #506


Summary

Fixes two ESLint errors (exit code 1) in the backend CI �ackend-checks job. These are not related to any open feature issue — they are standalone lint regressions in main.

Error 1 — \sorobanService.test.js:310:1\ — Parsing error: Unexpected token

The file uses bare \ est()\ calls (lines 258–309) but \ est\ was never imported from
ode:test. Only { describe, it, beforeEach, afterEach }\ were imported. ESLint's parser treated \ est\ as an unknown global and threw a parse error.

Fix: Added \ est\ to the destructured import on line 13.

Error 2 — \userDashboardService.js:227:21\ — Expected '===' and instead saw '==' (eqeqeq)

\\js
// Before
const str = value == null ? '' : String(value);
// After
const str = (value === null || value === undefined) ? '' : String(value);
\\

Both fixes are semantically equivalent — the behaviour does not change.


Note: The remaining 55 items in the CI output are warnings only — they do not cause the exit code 1 failure and are out of scope for this PR.

@dotunv
dotunv merged commit 17c7fa5 into Savitura:main Jul 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

a11y: replace hardcoded colors with CSS variables for dark mode support

2 participants