fix(lint): fix 2 CI errors — missing test import and eqeqeq violation - #544
Merged
Conversation
…eqeqeq in userDashboardService.js
…d add global to ESLint test globals
…y nested inside with:
…ture to match users.id type
…onflicts with latest main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #506
Summary
Fixes two ESLint errors (exit code 1) in the backend CI �ackend-checks job. These are not related to any open feature issue — they are standalone lint regressions in main.
Error 1 — \sorobanService.test.js:310:1\ — Parsing error: Unexpected token
The file uses bare \ est()\ calls (lines 258–309) but \ est\ was never imported from
ode:test. Only { describe, it, beforeEach, afterEach }\ were imported. ESLint's parser treated \ est\ as an unknown global and threw a parse error.
Fix: Added \ est\ to the destructured import on line 13.
Error 2 — \userDashboardService.js:227:21\ — Expected '===' and instead saw '==' (eqeqeq)
\\js
// Before
const str = value == null ? '' : String(value);
// After
const str = (value === null || value === undefined) ? '' : String(value);
\\
Both fixes are semantically equivalent — the behaviour does not change.