Duplicate const declaration crashes admin routes - #624
Merged
dotunv merged 2 commits intoJul 28, 2026
Merged
Conversation
…st declaration Adds a module-load regression test that verifies admin.js cannot be broken by duplicate const declarations of IMPERSONATION_TTL_SECONDS. - Test 1: Requires admin.js and fails only on SyntaxError - Test 2: Static source analysis to detect duplicate const declarations
Ensures admin.js is re-evaluated from scratch each test run, preventing cached modules from masking duplicate const errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #559
Description
This PR refactors and locks down the dynamic pricing edge cases and boundary conditions inside
contracts/stream/src/lib.rs. While the existing baseline logic successfully managed the primary happy-path calculation matrix, the state changes, gas consumptions, and boundary boundaries around extreme pricing inputs remained structurally implicit.By applying rigorous constraints around zero-liquidity pools, mathematical calculation overflows, near-infinite time deltas, and micro-precision rounding adjustments, we remove potential multi-transaction vectors for unexpected pricing anomalies. All changes maintain absolute backward compatibility with the current release version.
Changes
📈 Structural Contract Enhancements (
contracts/stream/src/lib.rs)🧪 Regression-Safe Test Engineering
📝 Operational Reference Guidelines
Verification Results
Checklist