Skip to content

Develop hclimrep forcings - #6

Open
ankitpatnala wants to merge 6 commits into
SavvasMel:develop-hclimrepfrom
ankitpatnala:develop-hclimrep_forcings
Open

Develop hclimrep forcings#6
ankitpatnala wants to merge 6 commits into
SavvasMel:develop-hclimrepfrom
ankitpatnala:develop-hclimrep_forcings

Conversation

@ankitpatnala

Copy link
Copy Markdown

Description

Added forcing implementation of mine

To add forcing stream,

For scalar, refer to forecast.yml
For 2d, refer to sst.yml

@SavvasMel

Copy link
Copy Markdown
Owner

The changes look bizarre, can you lint?

@ankitpatnala
ankitpatnala force-pushed the develop-hclimrep_forcings branch from 56818d2 to 63d18b6 Compare September 11, 2026 12:19
@ankitpatnala

Copy link
Copy Markdown
Author

The changes look bizarre, can you lint?

I did lint-check it shows okay now

[patnala1@jpbl-s01-03 WeatherGenerator]$ ./scripts/actions.sh lint-check
147 files already formatted
All checks passed!

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

There were few variables which was not initialized in the init function of model.py.
Are you referring to those when you say bizarre?

@SavvasMel

SavvasMel commented Sep 11, 2026

Copy link
Copy Markdown
Owner

The changes look bizarre, can you lint?

I did lint-check it shows okay now

[patnala1@jpbl-s01-03 WeatherGenerator]$ ./scripts/actions.sh lint-check
147 files already formatted
All checks passed!

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

There were few variables which was not initialized in the init function of model.py. Are you referring to those when you say bizarre?

Check here: https://github.com/SavvasMel/WeatherGenerator/pull/6/changes, the syntax seems weird in each file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants