Feat/explain4cut #172
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,83 @@ | ||||||
| import { X } from 'lucide-react'; | ||||||
| import { use4CutAiSummary } from '../hooks/use4CutAiSummary'; | ||||||
|
|
||||||
| interface Container4CutExplanationProps { | ||||||
| albumId: string; | ||||||
| eventName?: string; | ||||||
| eventDate?: string; | ||||||
| scale?: number; | ||||||
| width?: number; | ||||||
| isFinalized?: boolean; | ||||||
| onClose?: () => void; | ||||||
| } | ||||||
|
|
||||||
| const BASE_WIDTH = 216; | ||||||
| const BASE_HEIGHT = 384; | ||||||
| const BASE_ASPECT_RATIO = BASE_HEIGHT / BASE_WIDTH; | ||||||
|
|
||||||
| export default function Container4CutExplanation({ | ||||||
| albumId, | ||||||
| eventName, | ||||||
| eventDate, | ||||||
| scale = 1, | ||||||
| width, | ||||||
| isFinalized = false, | ||||||
| onClose, | ||||||
| }: Container4CutExplanationProps) { | ||||||
| const calculatedWidth = width ?? BASE_WIDTH * scale; | ||||||
| const calculatedHeight = calculatedWidth * BASE_ASPECT_RATIO; | ||||||
| const { aiSummary, isLoading } = use4CutAiSummary(albumId); | ||||||
|
|
||||||
| return ( | ||||||
| <div | ||||||
| className='bg-element-letter relative overflow-hidden font-medium' | ||||||
|
Contributor
There was a problem hiding this comment. 자식 요소의 높이 문제로 인한 레이아웃 깨짐을 방지하기 위해, 이 컨테이너를 flexbox 컨테이너로 만드는 것을 제안합니다.
Suggested change
|
||||||
| style={{ | ||||||
| width: `${calculatedWidth}px`, | ||||||
| height: `${calculatedHeight}px`, | ||||||
| borderRadius: '8px', | ||||||
| ...(isFinalized && { | ||||||
| boxShadow: '0px 0px 25px 5px rgba(0, 0, 0, 0.08)', | ||||||
| }), | ||||||
| }} | ||||||
|
Comment on lines
+38
to
+41
Contributor
There was a problem hiding this comment. 인라인 스타일 대신 Tailwind CSS 클래스를 사용하여 조건부 스타일을 적용하는 것이 유지보수 측면에서 더 좋습니다. |
||||||
| > | ||||||
| {/* 헤더: 제목 + 날짜 + X 버튼 */} | ||||||
| <div className='flex justify-between p-4'> | ||||||
| <div className='flex flex-col gap-1'> | ||||||
| <h2 className='text-text-basic typo-body-lg-semibold'> | ||||||
| {eventName || '인생네컷'} | ||||||
| </h2> | ||||||
| {eventDate && ( | ||||||
| <p className='text-text-subtler typo-caption-sm-medium'> | ||||||
| {eventDate} | ||||||
| </p> | ||||||
| )} | ||||||
| </div> | ||||||
| {/* X 버튼 */} | ||||||
| <button | ||||||
| onClick={onClose} | ||||||
| className='rounded-full p-1 transition-colors hover:bg-gray-100' | ||||||
| aria-label='닫기' | ||||||
| > | ||||||
| <X className='text-text-secondary h-5 w-5' /> | ||||||
| </button> | ||||||
| </div> | ||||||
|
|
||||||
| {/* Body: 텍스트 설명 */} | ||||||
| <div className='flex h-full flex-col justify-center p-4'> | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
|
||||||
| <div className='bg-surface-white rounded-lg p-4'> | ||||||
| {isLoading ? ( | ||||||
| <div className='flex items-center justify-center py-8'> | ||||||
| <div className='text-text-secondary text-sm'> | ||||||
| AI 요약 생성 중... | ||||||
| </div> | ||||||
| </div> | ||||||
| ) : ( | ||||||
| <p className='text-text-basic text-sm leading-relaxed whitespace-pre-wrap'> | ||||||
| {aiSummary} | ||||||
| </p> | ||||||
| )} | ||||||
| </div> | ||||||
| </div> | ||||||
| </div> | ||||||
| ); | ||||||
| } | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,34 @@ | ||||||
| import { ApiReturns, EP } from '@/global/api/ep'; | ||||||
| import { api } from '@/global/utils/api'; | ||||||
| import { useQuery } from '@tanstack/react-query'; | ||||||
|
|
||||||
| const fetchAiSummary = async (albumId: string) => { | ||||||
| const response = await api.get<ApiReturns['cheese4cut.cheese4cutAiSummary']>({ | ||||||
| path: EP.cheese4cut.cheese4cutAiSummary(albumId), | ||||||
| }); | ||||||
|
|
||||||
| return response.result; | ||||||
| }; | ||||||
|
|
||||||
| export function use4CutAiSummary(albumId: string) { | ||||||
| const query = useQuery({ | ||||||
| queryKey: [EP.cheese4cut.cheese4cutAiSummary(albumId)], | ||||||
| queryFn: () => fetchAiSummary(albumId), | ||||||
| refetchInterval: (query) => { | ||||||
| // COMPLETED 상태면 polling 중단 | ||||||
| if (query.state.data?.status === 'COMPLETED') { | ||||||
| return false; | ||||||
| } | ||||||
| // 아니면 30초마다 polling | ||||||
| return 30000; | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
|
||||||
| }, | ||||||
| refetchIntervalInBackground: false, | ||||||
| }); | ||||||
|
|
||||||
| return { | ||||||
| ...query, | ||||||
| aiSummary: query.data?.content || '', | ||||||
| isCompleted: query.data?.status === 'COMPLETED', | ||||||
| title: query.data?.title || '', | ||||||
| }; | ||||||
| } | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
인라인 스타일 대신 Tailwind CSS 클래스를 사용하여 조건부 스타일을 적용하는 것이 유지보수 측면에서 더 좋습니다.
boxShadow를 별도의 클래스로 정의하고isFinalized값에 따라 동적으로 클래스를 적용하는 것을 고려해보세요. 예를 들어,clsx와 같은 유틸리티를 사용할 수 있습니다.