Add some pre-build funtions and tests #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
qtzhuang
commented
Nov 14, 2023
qtzhuang
commented
- add AngleEmbedding
- add BasicEntangleLayer
- For supporting the above functions, add "add_gates" function in QuantumCircuit temporarily
- tests or example has been also added
- amplitude embedding will be added soon
Zhaoyilunnn
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Thanks for the great work. In general this PR looks good to me, future improvements may include
- using some tools like black to unity the coding style, this can easily avoid some minors like missing white spaces.
- refer to pennylane or other opensource projects and read their unit tests, figuring out how they write ut for circuit templates and improve our ut.
| rotation(str): one-parameter single-qubit gate to use | ||
| """ | ||
| weights = np.asarray(weights) | ||
| """convert weights to numpy array if weights is list otherwise keep unchanged""" |
There was a problem hiding this comment.
minor: inline comments should start with "#"
|
|
||
| elif self.num_qubits > 2: | ||
| for i in range(self.num_qubits): | ||
| gate_list.append(qeg.CXGate(i,(i+1)%self.num_qubits)) |
There was a problem hiding this comment.
missing space between i and (i+1) ...
There was a problem hiding this comment.
thanks～，I humbly accept the above suggestions and make better work~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.