New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: openmp typo #134

Merged

Zhaoyilunnn merged 2 commits into ScQ-Cloud:master from Zhaoyilunnn:master

Jan 18, 2024

Collaborator

Zhaoyilunnn commented Jan 17, 2024

build job failed on windows: https://github.com/ScQ-Cloud/pyquafu/actions/runs/7552526187/job/20561548536?pr=133

errors
1. statevector.hpp(1305): error C3001: 'paraleel': expected an OpenMP directive name
2. statevector.hpp(1315): error C3016: 'j': index variable in OpenMP 'for' statement must have signed integral type


          fix: openmp typo

214e481

Zhaoyilunnn requested a review from lss0208

January 17, 2024 11:06

lss0208 reviewed

View reviewed changes

Collaborator

lss0208 left a comment

I suggest use 'omp_i' instead 'int' inside the loop of omp.


          fix: use omp_i instead of int

3a55f83

Zhaoyilunnn requested a review from lss0208

January 17, 2024 14:34

lss0208 approved these changes

View reviewed changes

Zhaoyilunnn merged commit 862cb63 into ScQ-Cloud:master

34 of 35 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet