Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Fix the init part of User class #29

Merged
merged 2 commits into from
Jul 23, 2023

Conversation

Alndaly
Copy link
Contributor

@Alndaly Alndaly commented Jul 22, 2023

Fix: When user first use this python library, he or she will not be able to import User class successfully because of the self.load_account() in the __init__ part of the User class.

@Alndaly Alndaly changed the base branch from master to dev July 22, 2023 16:31
@Alndaly Alndaly changed the base branch from dev to master July 22, 2023 16:36
Copy link
Collaborator

@Zhaoyilunnn Zhaoyilunnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me besides the minor style issue

self.load_account()


if(self.check_account_data()):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add an space if (self.xxx)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, please check again.

@Zhaoyilunnn Zhaoyilunnn merged commit 7fb9389 into ScQ-Cloud:master Jul 23, 2023
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants