Replace pygraphviz with graphviz
#80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decouple from IPython, pygraphviz
Though the newest version is 0.20.1, 0.14.1 works fine already.
Zhaoyilunnn
reviewed
Sep 13, 2023
| @@ -253,9 +253,7 @@ def send(self, | |||
| raise UserError() | |||
| else: | |||
| res_dict = response.json() | |||
| import pprint | |||
There was a problem hiding this comment.
I assume that you want to use the verbose flag to control whether we print response, so you finally decide to remove this now? If so, maybe the verbose flag should be deleted.
There was a problem hiding this comment.
Actually I intended to help debug by setting verbose=True, yet it was not completed. Let's delete it for now. By the way I just noticed status_code in two level in master branch were not seperated yet?
There was a problem hiding this comment.
I believe this is a mistake I made when I merge stable/0.3 branch into master. When resolving conflicts, I mistakenly removed the change in stable/0.3 branch and kept the master branch change. I will fix this later.
Zhaoyilunnn
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering python package
graphvizis more lightweight, installation-flexible, well-documented and simple to use, implemented draw_dag() withgraphvizand removedpygraphviz. Dependence uponIPythonwas also removed since this is not generally compatiable with different ways to runpyquafu. Instead supports for notebook users should be tested and documented independently in the later development -- luckily, it seems `graphviz`` does well in the aspect.