Merge pull request #198 from SceneGate/feature/net8

✨ Support .NET 8.0
SceneGate · Nov 23, 2023 · 8283cd2 · 8283cd2
2 parents 47db290 + 0d613ff
commit 8283cd2
Show file tree

Hide file tree

Showing 14 changed files with 24 additions and 71 deletions.
diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -9,7 +9,7 @@
             "type": "coreclr",
             "request": "launch",
             "preLaunchTask": "Build release",
-            "program": "${workspaceFolder}/src/Yarhl.PerformanceTests/bin/Release/net6.0/Yarhl.PerformanceTests.dll",
+            "program": "${workspaceFolder}/src/Yarhl.PerformanceTests/bin/Release/net8.0/Yarhl.PerformanceTests.dll",
             "args": [ "auto" ],
             "cwd": "${workspaceFolder}",
             "stopAtEntry": false,

diff --git a/README.md b/README.md
@@ -110,33 +110,28 @@ Some cool projects built with _Yarhl_:
 
 ## Contributing
 
-The repository requires to build .NET 6.0 SDK and .NET Framework 4.8 or latest
-Mono (for DocFX). If you open the project with VS Code and you did install the
-[VS Code Remote Containers](https://code.visualstudio.com/docs/remote/containers)
-extension, you can have an already pre-configured development environment with
-Docker or Podman.
+The repository requires to build .NET 8.0 SDK.
 
 To build, test and generate artifacts run:
 
 ```sh
-# Only required the first time
-dotnet tool restore
+# Build and run tests
+dotnet run --project build/orchestrator
 
-# Default target is "Default" that builds, runs tests, build doc and create the NuGets
-dotnet cake
-```
-
-To just build and test quickly, run:
-
-```sh
-dotnet cake --target=BuildTest
+# (Optional) Create bundles (nuget, zips, docs)
+dotnet run --project build/orchestrator -- --target=Bundle
 ```
 
 Additionally you can use _Visual Studio_ or _JetBrains Rider_ as any other .NET
 project.
 
 To contribute follow the [contributing guidelines](CONTRIBUTING.md).
 
+### How to release
+
+Create a new _GitHub release_ with a tag name `v{Version}` (e.g. `v2.4`) and
+that's it! This triggers a pipeline that builds and deploy the project.
+
 ## License
 
 The software is licensed under the terms of the

diff --git a/build/orchestrator/PrepareIntegrationTestsTask.cs b/build/orchestrator/PrepareIntegrationTestsTask.cs
@@ -12,13 +12,13 @@ public class PrepareIntegrationTestsTask : FrostingTask<PleOpsBuildContext>
     public override void Run(PleOpsBuildContext context)
     {
         // Copy a good and bad plugin to test the assembly load logic
-        string pluginPath = $"src/Yarhl.Media.Text/bin/{context.DotNetContext.Configuration}/net6.0/Yarhl.Media.Text.dll";
         string badPluginPath = context.DotNetContext.SolutionPath; // this isn't a DLL for sure :D
 
         string outputBasePath = $"src/Yarhl.IntegrationTests/bin/{context.DotNetContext.Configuration}";
         string testProjectPath = "src/Yarhl.IntegrationTests/Yarhl.IntegrationTests.csproj";
 
         foreach (string framework in GetTargetFrameworks(testProjectPath)) {
+            string pluginPath = $"src/Yarhl.Media.Text/bin/{context.DotNetContext.Configuration}/{framework}/Yarhl.Media.Text.dll";
             string pluginDir = $"{outputBasePath}/{framework}/Plugins";
             _ = Directory.CreateDirectory(pluginDir);
             File.Copy(pluginPath, $"{pluginDir}/Yarhl.Media.Text.dll", true);

diff --git a/docs/index.md b/docs/index.md
@@ -15,7 +15,7 @@ formats** It empowers you with...
 ## Usage
 
 The project has the following .NET libraries (NuGet packages via nuget.org). The
-libraries only support the latest .NET LTS version: **.NET 6.0**.
+libraries only support .NET LTS versions: **.NET 6.0** and **.NET 8.0**.
 
 - [![Yarhl](https://img.shields.io/nuget/v/Yarhl?label=Yarhl&logo=nuget)](https://www.nuget.org/packages/Yarhl)
   - `Yarhl.FileFormat`: format conversion APIs.

diff --git a/src/Yarhl.Examples/Yarhl.Examples.csproj b/src/Yarhl.Examples/Yarhl.Examples.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
 
     <GenerateDocumentationFile>false</GenerateDocumentationFile>

diff --git a/src/Yarhl.IntegrationTests/Yarhl.IntegrationTests.csproj b/src/Yarhl.IntegrationTests/Yarhl.IntegrationTests.csproj
@@ -3,7 +3,7 @@
 
   <PropertyGroup>
     <Description>Plugin integration tests for Yarhl.</Description>
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFrameworks>net6.0;net8.0</TargetFrameworks>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/Yarhl.Media.Text/Yarhl.Media.Text.csproj b/src/Yarhl.Media.Text/Yarhl.Media.Text.csproj
@@ -5,7 +5,7 @@
     <Description>Library with Yarhl converters for text formats.</Description>
     <IsPackable>true</IsPackable>
 
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFrameworks>net6.0;net8.0</TargetFrameworks>
 
     <Nullable>enable</Nullable>
   </PropertyGroup>

diff --git a/src/Yarhl.PerformanceTests/Yarhl.PerformanceTests.csproj b/src/Yarhl.PerformanceTests/Yarhl.PerformanceTests.csproj
@@ -4,7 +4,7 @@
   <PropertyGroup>
     <OutputType>Exe</OutputType>
     <Description>Performance tests for Yarhl.</Description>
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
 
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
   </PropertyGroup>

diff --git a/src/Yarhl.Plugins/Yarhl.Plugins.csproj b/src/Yarhl.Plugins/Yarhl.Plugins.csproj
@@ -4,7 +4,7 @@
     <Description>Assembly scaning for file formats and converters implemented with Yarhl.</Description>
     <IsPackable>true</IsPackable>
 
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFrameworks>net6.0;net8.0</TargetFrameworks>
 
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>

diff --git a/src/Yarhl.UnitTests/Yarhl.UnitTests.csproj b/src/Yarhl.UnitTests/Yarhl.UnitTests.csproj
@@ -3,7 +3,7 @@
 
   <PropertyGroup>
     <Description>Yarhl unit tests.</Description>
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFrameworks>net6.0;net8.0</TargetFrameworks>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/Yarhl/FileFormat/ConvertFormat.Obsolete4.cs b/src/Yarhl/FileFormat/ConvertFormat.Obsolete4.cs
@@ -73,7 +73,10 @@ public static object With<TConv, TParam>(TParam param, dynamic src)
     public static object With(IConverter converter, dynamic src)
     {
         ArgumentNullException.ThrowIfNull(converter);
-        ArgumentNullException.ThrowIfNull(src);
+        if (src is null) {
+            throw new ArgumentNullException(nameof(src));
+        }
+
         ValidateConverterType(converter.GetType(), src.GetType());
 
         return ((dynamic)converter).Convert(src);

diff --git a/src/Yarhl/Yarhl.csproj b/src/Yarhl/Yarhl.csproj
@@ -5,7 +5,7 @@
     <Description>Library with features for implementing file formats, converters and a virtual file system.</Description>
     <IsPackable>true</IsPackable>
 
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFrameworks>net6.0;net8.0</TargetFrameworks>
 
     <Nullable>enable</Nullable>
   </PropertyGroup>