Skip to content

Conversation

@kalmanbencze
Copy link
Contributor

@kalmanbencze kalmanbencze commented Oct 24, 2025

Changes:

  • using libs.versions.toml file for declaration of library versions
  • rewrote build.gradle -> build.gradle.kts with necessary modernization
  • rewrote the buildSrc contents/ renamed to build-logic to define convention plugins
  • Rewrote the groovy FilamentPlugin.kt in kotlin
  • upgraded gradle to gradle-8.14.3
  • tested the plugin to convert the resources + samples to verify them
  • updated workflows to run on jvm 21

Testing

  • regenerated all resources with the rewritten plugin
  • tested all samples
  • published the libraries to local maven to make sure the publishing works as before

@kalmanbencze
Copy link
Contributor Author

hey @ThomasGorisse @grassydragon, I got one more change here to modernise the repo a bit. Let me know if I should try and break it into more pieces, although the groovy to kts gradle dsl change would be hard to do one by one

Copy link
Contributor

@grassydragon grassydragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are my comments after reading through the changes. I'll also try checking out the branch and building the project.

I'd like to hear @ThomasGorisse's opinion on the changes related to publishing.

//
// Needed if you want to generate Materials, Indirect Light (IBL) and Skyboxes.
//
// 1) Copy/paste the /buildSrc dir into your project root folder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the plugin code is now located in build-logic, the manual for adding it to your own project should be updated.

By the way, do you think it's possible to release the plugin as a part of Sceneview? So it can be included as a dependency instead of copying the code.

Copy link
Contributor Author

@kalmanbencze kalmanbencze Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I think so, I'll set it up, and if works, I'll update the readme with how to add and run the plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants