-
-
Couldn't load subscription status.
- Fork 197
Upgraded gradle build config to use KTS and misc improvements #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ces with the latest filament binaries.
Gradle build system upgrade
|
hey @ThomasGorisse @grassydragon, I got one more change here to modernise the repo a bit. Let me know if I should try and break it into more pieces, although the groovy to kts gradle dsl change would be hard to do one by one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are my comments after reading through the changes. I'll also try checking out the branch and building the project.
I'd like to hear @ThomasGorisse's opinion on the changes related to publishing.
arsceneview/build.gradle.kts
Outdated
| // | ||
| // Needed if you want to generate Materials, Indirect Light (IBL) and Skyboxes. | ||
| // | ||
| // 1) Copy/paste the /buildSrc dir into your project root folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the plugin code is now located in build-logic, the manual for adding it to your own project should be updated.
By the way, do you think it's possible to release the plugin as a part of Sceneview? So it can be included as a dependency instead of copying the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm I think so, I'll set it up, and if works, I'll update the readme with how to add and run the plugin
build-logic/configuration/src/main/kotlin/io/github/sceneview/FilamentPlugin.kt
Show resolved
Hide resolved
build-logic/configuration/src/main/kotlin/io/github/sceneview/FilamentPlugin.kt
Outdated
Show resolved
Hide resolved
enabled publishing for the tools plugin as well
added more ignored folders for module detection script
Changes:
Testing