-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mypy schema #3422
feat: add mypy schema #3422
Conversation
Signed-off-by: Henry Schreiner <[email protected]>
Thanks! I was wondering your thoughts on using the name There seems to be a common use case for schemas that are their own file, and only meant to be referenced/ I think that this name would make it more obvious that the schema is an internal abstraction, solely to make editing schemas in this repository easier. For example, when IDEs prompt a user to explicitly select a JSON schema to use, they can potentially ignore entries that match |
(I saw your python/mypy#16601 PR, and I'm working on something similar with jsonschema-extractor, and I think deciding on an informal convention would be beneficial.) |
Unstable sounds like it should not be used. It's actually very useful on its own; I'm using them with validate-pyproject (PR merged, but unreleased so far), which expects the schema to describe the tool section. Possible "partial-pyproject-mypy.json" or "internal-pyproject-mypy.json". I don't mind the "internal", but not fond of the "unstable". (I'm working on a followup that will load all ref'd schemas in a "store" file (the pyproject.toml one), so the names won't actually be all that exposed soon.) Validate-pyproject PRs: |
I see - yeah on second thought, neither 'unstable' or 'internal' are not good names for most of these schemas. I didn't think that some validators could use our URLs to explicitly validate a subschema. The name How about this:
|
Are you suggesting |
I was a bit vague - |
And are you suggesting we change poetry, scikit-build, and setuptools? (hatch, cibuildwheel, and ruff all also can stand alone). (In a later PR, of course) |
Signed-off-by: Henry Schreiner <[email protected]>
I do have a slight preference to rename those instances in a backwards-compatible way. For example, renaming If you'd like, I can make the PR doing this. If you aren't in favor, then we can keep poetry skikit-build and setuptools as they are, without changes. |
Co-authored-by: Henry Schreiner <[email protected]>
thanks! |
Hi, this is great! I am getting two error messages in my
Some infos on those:
|
@bersbersbers thanks for the report, I have created issue #3467 to track it |
This adds a schema for mypy.