Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sigma): update broken schema url #4098

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

sventec
Copy link
Contributor

@sventec sventec commented Sep 24, 2024

This PR fixes the Sigma schema introduced in #3455. The schema referenced in that PR has since been renamed and updated, and additional schemas now exist (correlation [meta] rules and global filters).

This PR is limited to updating the Sigma rule schema to the current link, as well as clarifying the name and description to avoid ambiguity in the presence of multiple schemas in the SigmaHQ/sigma-specification repo.

I'm not sure whether it would be feasible to implement matching for the other Sigma schemas. Maybe someone more knowledgeable could chime in, but I'm presently unaware of any standard file naming convention that could reliably differentiate between Sigma-associated file subtypes. For now, my goal is to fix the existing Sigma detection rule schema present in SchemaStore.

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@hyperupcall
Copy link
Member

Thanks

@hyperupcall hyperupcall merged commit 9fce73d into SchemaStore:master Sep 24, 2024
4 checks passed
@hyperupcall
Copy link
Member

hyperupcall commented Sep 24, 2024

@sventec Hello! There is no file naming standards for Sigma, the alternatives are to make a match based on particular properties of the YAML file name or on the presence of a particular file in the root directory. Feature requested in #3658 #3460 #3965

@sventec sventec deleted the fix-sigma branch September 24, 2024 19:04
benpops89 pushed a commit to benpops89/schemastore that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants