Resolved open issues #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r end date" This reverts commit ad54f42.
…f-00XXX00 Warning triggered if infinity_indicator found in SSIM start or end date
…coding-formats use determined encoding format for importing
- as some airlines deviate from SSIM standards, seat classes were left over and thereby not read by the algorithm. Instead, by focusing on provided information one is able to read all seat classes. - introduced acv_splitter to make distinction relevant acv info and aircraft version reference code
…seat-order focus on provided instead of expected aircraft_configuration_string
This was
linked to
issues
Feb 25, 2021
rok
reviewed
Feb 25, 2021
There was a problem hiding this comment.
Looks great Timo! I've added some comments off the top of my head.
I would recommend you add an example test case of the problem you're fixing for here. See an example case here: https://github.com/Schiphol-Hub/ssim/blob/master/test/data/slots_netherlands.yml. pytest tests can then be used to make sure this change did indeed solve the problem and did not violate another expectation we have for the parser.
FlorisHoogenboom
suggested changes
Mar 1, 2021
There was a problem hiding this comment.
Looks great @timonoortman-aas. Could you check the failing build what is going on there?
- main adjustment is that encoding format could be provided as keyword argument (instead of inferring encoding format in code)
|
@FlorisHoogenboom Could you please review it again? |
|
Can I help push this along somehow? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The three open issues have been resolved in this pull request: