Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: switch to sass-embedded and remedy sass API deprecation warnings #1926

Merged
merged 11 commits into from
Oct 9, 2024
Merged

chore: switch to sass-embedded and remedy sass API deprecation warnings #1926

merged 11 commits into from
Oct 9, 2024

Conversation

JoCa96
Copy link
Collaborator

@JoCa96 JoCa96 commented Oct 7, 2024 •
edited
Loading

  • add sass-embedded to catalog and use it instead of sass
  • add workspace package @sit-onyx/shared for shared configs
    • add vite.config.base.ts file for shared Vite base config
    • right now we can't use a module import because of an open Vite issue.
      We have to use a relative import instead.

@JoCa96 JoCa96 requested a review from a team as a code owner October 7, 2024 10:54
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 492d0db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JoCa96 JoCa96 force-pushed the chore-get-rid-of-sass-deprecation-warnings branch from 462d71b to dbffb7e Compare October 7, 2024 11:11
larsrickert
larsrickert requested changes Oct 7, 2024
View reviewed changes
apps/demo-app/vite.config.ts Show resolved Hide resolved
apps/docs/vite.config.ts Outdated Show resolved Hide resolved
packages/shared/package.json Outdated Show resolved Hide resolved
pnpm-workspace.yaml Outdated Show resolved Hide resolved
@larsrickert larsrickert self-assigned this Oct 7, 2024
@JoCa96 JoCa96 requested a review from larsrickert October 8, 2024 06:44
@JoCa96 JoCa96 enabled auto-merge (squash) October 8, 2024 06:44
larsrickert
larsrickert previously approved these changes Oct 8, 2024
View reviewed changes
@JoCa96 JoCa96 force-pushed the chore-get-rid-of-sass-deprecation-warnings branch from 1e63263 to 09e9de8 Compare October 8, 2024 14:19
@JoCa96 JoCa96 force-pushed the chore-get-rid-of-sass-deprecation-warnings branch from 09e9de8 to ce0e6bf Compare October 8, 2024 14:21
larsrickert
larsrickert requested changes Oct 8, 2024
View reviewed changes
packages/shared/index.ts Outdated Show resolved Hide resolved
@JoCa96 JoCa96 requested a review from larsrickert October 9, 2024 06:43
@JoCa96 JoCa96 merged commit 68f0b4f into main Oct 9, 2024
19 checks passed
@JoCa96 JoCa96 deleted the chore-get-rid-of-sass-deprecation-warnings branch October 9, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsrickert larsrickert larsrickert approved these changes

Assignees

@larsrickert larsrickert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoCa96 @larsrickert