276 feature request enhance sbbtextstyles for easier use of other text styles #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
smallTrogdor
requested changes
Feb 3, 2025
| /// Use [sbbFont] instead. | ||
| @Deprecated('Use sbbFont instead') | ||
| @Deprecated( | ||
| 'Use of sbbWebFont was deprecated and replaced by sbbFont for a clearer and more consistent naming convention ' |
There was a problem hiding this comment.
missing punctuation ... naming convention . ...
| @Deprecated('Use sbbFont instead') | ||
| @Deprecated( | ||
| 'Use of sbbWebFont was deprecated and replaced by sbbFont for a clearer and more consistent naming convention ' | ||
| 'This feature was deprecated after v2.2.0.', |
| /// When in need of a more custom text style, consider using the extension methods defined in [TextStylesExtensions]. | ||
| /// The intended way to use this is to start with [sbbTextStyle] and use the corresponding methods to achieve the | ||
| /// desired [TextStyle]: | ||
| /// ```dart |
| ); | ||
| } | ||
|
|
||
| extension TextStylesExtensions on TextStyle { |
| class SBBTextStyles { | ||
| SBBTextStyles._(); | ||
|
|
||
| // Font families |
There was a problem hiding this comment.
I would create a separate class for these.
e.g. SBBFontFamilies
It seems a bit weird, that you call SBBTextStyles.sbbFontUltraLight for getting a FontFamily
| // Font families | ||
|
|
||
| /// Returns an ultra light ([fontFamily]) copy of this text style | ||
| TextStyle get ultraLightStyle => copyWith(fontFamily: SBBTextStyles.sbbFontUltraLight); |
There was a problem hiding this comment.
This confused me a bit with the
fontFamily: SBBTextStyles. ...
Would do SBBFontFamilies (and maybe even private to the lib and not expose this one ? )
| static const String sbbFontCondensedBold = 'packages/sbb_design_system_mobile/SBBWebCondensedBold'; | ||
| static const String sbbFontCondensedHeavy = 'packages/sbb_design_system_mobile/SBBWebCondensedHeavy'; | ||
|
|
||
| // Font sizes |
There was a problem hiding this comment.
maybe also for these a separate class 🤔 but I guess that breaks backwards compatibility ...
| @@ -41,21 +41,27 @@ flutter: | |||
| - lib/assets/illustrations/dark/ | |||
| - lib/assets/illustrations/light/ | |||
| fonts: | |||
| - family: SBBWeb | |||
There was a problem hiding this comment.
nice for adding those tests 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.