Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

276 feature request enhance sbbtextstyles for easier use of other text styles #279

Conversation

VanHoangTran
Copy link
Collaborator

No description provided.

@VanHoangTran VanHoangTran requested a review from a team as a code owner January 30, 2025 16:18
@VanHoangTran VanHoangTran linked an issue Jan 30, 2025 that may be closed by this pull request
2 tasks
@VanHoangTran VanHoangTran reopened this Jan 31, 2025
Copy link
Contributor

@smallTrogdor smallTrogdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small comments, biggest one is the consideration of adding SBBFontFamilies
(as package private) instead of adding this also to the SBBTextStyles class ..

One more thing: Please update the CHANGELOG accordingly. 😄 good work 🥇

lib/src/theme/sbb_typography.dart Outdated Show resolved Hide resolved
lib/src/theme/sbb_typography.dart Show resolved Hide resolved
/// When in need of a more custom text style, consider using the extension methods defined in [TextStylesExtensions].
/// The intended way to use this is to start with [sbbTextStyle] and use the corresponding methods to achieve the
/// desired [TextStyle]:
/// ```dart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice 👀

);
}

extension TextStylesExtensions on TextStyle {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff 💯

lib/src/theme/sbb_typography.dart Outdated Show resolved Hide resolved
lib/src/theme/sbb_typography.dart Outdated Show resolved Hide resolved
lib/src/theme/sbb_typography.dart Show resolved Hide resolved
@@ -41,21 +41,27 @@ flutter:
- lib/assets/illustrations/dark/
- lib/assets/illustrations/light/
fonts:
- family: SBBWeb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice for adding those tests 💯

Copy link
Contributor

@smallTrogdor smallTrogdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - awesome work @VanHoangTran 🤩

@VanHoangTran VanHoangTran merged commit e8adc9e into main Feb 4, 2025
8 checks passed
@VanHoangTran VanHoangTran deleted the 276-feature-request-enhance-sbbtextstyles-for-easier-use-of-other-text-styles branch February 4, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Enhance SBBTextStyles for easier use of other text styles
2 participants