Bugfix for false positive of the tagging tape for MPI reduce operations.

SciCompKL · Apr 3, 2024 · f24b03f · f24b03f
1 parent 9b6b905
commit f24b03f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/include/codi/tapes/tagging/tagTapeBase.hpp b/include/codi/tapes/tagging/tagTapeBase.hpp
@@ -85,7 +85,8 @@ namespace codi {
       /// Callback for a tag error.
       using TagErrorCallback = void (*)(Tag const& correctTag, Tag const& wrongTag, void* userData);
 
-      static Tag constexpr PassiveTag = Tag(0);  ///< Tag indicating an inactive value.
+      static Tag constexpr PassiveTag = Tag(0);   ///< Tag indicating an inactive value.
+      static Tag constexpr InvalidTag = Tag(-1);  ///< Tag indicating an invalid value.
 
     protected:
 
@@ -223,7 +224,7 @@ namespace codi {
 
       /// Checks if the tag is correct. Errors are set on the ValidationIndicator object.
       CODI_INLINE void verifyTag(ValidationIndicator<Real, Tag>& vi, Tag const& tag) const {
-        if (PassiveTag != tag) {
+        if (PassiveTag != tag && InvalidTag != tag) {
           vi.isActive = true;
           if (tag != curTag) {
             vi.hasError = true;

diff --git a/include/codi/tapes/tagging/tagTapeReverse.hpp b/include/codi/tapes/tagging/tagTapeReverse.hpp
@@ -250,7 +250,7 @@ namespace codi {
 
       /// -1 tag.
       Identifier getInvalidIndex() const {
-        return Identifier(-1);
+        return Identifier(Base::InvalidTag);
       }
 
       /// Verify tag.