Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

69 - Transition setup.py to pyproject.toml #72

Merged
merged 18 commits into from
Sep 7, 2023
Merged

69 - Transition setup.py to pyproject.toml #72

merged 18 commits into from
Sep 7, 2023

Conversation

mxochicale
Copy link
Contributor

Addressing #69

thompson318
thompson318 reviewed Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@thompson318 thompson318 left a comment •
edited by mxochicale
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused. I thought we were moving away from tox. Historically we've used tox to install the requirements defined in requirements-dev.txt, so if tox is added to them what are we going to use to install?

MX: As discussed. I have added few packages to requirements-dev.txt for developing the package. Thanks, --Miguel

thompson318
thompson318 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@thompson318 thompson318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I get it now.

@mxochicale
distilling steps, adds ssh ref and updates gitignore list for dev (#69)
ed69dbe
@mxochicale
adds pyproject.toml and works locally, removes setup.py for the main …
90b6b40 
…repo; and updates gitignore (#69)
@mxochicale
optimise imports, reformats code tests/test_template (#69)
1e07e4c
@mxochicale
cosmetic changes to main README (#69)
72d26af
@mxochicale
removes obsolte weisslab, cmic and gitlab references (#69, #43)
2d15ec4
@mxochicale
adds {{cookiecutter.project_slug}}/pyproject.toml & locally tested; r…
83d0cb6 
…emoves setup.cfg&setup.py (#69)
@mxochicale
temporally skipping test_requirements_vs_setup() for the migration to…
6dcfd44 
… pyproject.toml (#69)
@mxochicale
refactors skip condition when there is no setup.py and udpates ci f…
5c4399d 
…or remote unit tests (#69)
@mxochicale
minor cosmetic changes (#69)
b237e6a
@mxochicale
removing doc in ./tests/ at {{cookiecutter.project_slug}}/tox.ini (#69)
12bad6c
@mxochicale
updates keyworks in pyproject.toml files (#69)
f2442bf
@mxochicale
updates around tox to build docs and its requirements (#69)
0594013
@mxochicale
remove unecessary python versions in template/tox.ini (#69)
859cf00
@mxochicale
cleaner workflow (#69)
ac52a2a
@mxochicale
refactoring pyproject.toml to pass tox local tests (#69)
bf61ec1
@mxochicale
passed local pytest, pylint, coverage using tox for template (#69)
14f50c7
@mxochicale mxochicale marked this pull request as ready for review August 23, 2023 09:52
@mxochicale
Copy link
Contributor Author

Hi @thompson318 , this PR is ready for review. Let me know if you have further comments, otherwise it should be ready to be merged. Thanks, --Miguel

@mxochicale mxochicale merged commit 2e7041d into master Sep 7, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompson318 thompson318 thompson318 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mxochicale @thompson318