Issue #78 get_frame should return either a string or a tuple

SciKit-Surgery · Sep 27, 2023 · 08f1677 · 08f1677
1 parent 44bd71d
commit 08f1677
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/tests/polaris_mocks.py b/tests/polaris_mocks.py
@@ -100,8 +100,10 @@ def mockndiGetBXTransform(self, _device, _port_handle): #pylint:disable=invalid-
         sksurgerycore.tests.algorithms
         """
         assert self.bx_frame_count > 0
-
-        return concatenate((self.rotation, self.position, self.quality))
+        #the base ndicapi library uses Py_BuildValue to return the transform
+        #as a tuple of double float values, so let's make sure we're als
+        #returning a tuple
+        return tuple(concatenate((self.rotation, self.position, self.quality)))
 
     def mockndiGetBXTransformMissing(self, _device, _port_handle): #pylint:disable=invalid-name
         """Mock of ndiGetBXTransform"""

diff --git a/tests/test_sksurgerynditracker_mockndi_getframe.py b/tests/test_sksurgerynditracker_mockndi_getframe.py
@@ -62,8 +62,8 @@ def test_getframe_missing(mocker):
             bxsource.mockndiGetBXTransformMissing)
 
     tracker = NDITracker(SETTINGS_POLARIS)
-    (port_handles, time_stamps, frame_numbers, tracking,
-                tracking_quality ) = tracker.get_frame()
+    (port_handles, time_stamps, frame_numbers, _tracking,
+                _tracking_quality ) = tracker.get_frame()
     print (port_handles)
     print (time_stamps)
     print (frame_numbers)