Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aviti FCs to bioinfo tab #441

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aanil
Copy link

@aanil aanil commented Nov 6, 2024

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 7.89474% with 70 lines in your changes missing coverage. Please review.

Project coverage is 28.86%. Comparing base (3b312b0) to head (f4d4d6c).

Files with missing lines Patch % Lines
taca/utils/bioinfo_tab.py 0.00% 67 Missing ⚠️
taca/element/Element_Runs.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
- Coverage   29.05%   28.86%   -0.20%     
==========================================
  Files          31       31              
  Lines        4898     4941      +43     
==========================================
+ Hits         1423     1426       +3     
- Misses       3475     3515      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kedhammar
Copy link

Not familiar with this part of TACA, but the changes look reasonable to me.

Request versionlog update.

@aanil
Copy link
Author

aanil commented Nov 6, 2024

Not familiar with this part of TACA, but the changes look reasonable to me.

Request versionlog update.

Will do when it's ready to merge, so that the dates are right.

logger.info(f"Working on {run_dir}")
update_statusdb(run_dir, inst_brand)
elif inst_brand == "element":
logger.info(f"Working on {run_dir}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to have some kind of regular expression to check for a rundir here as well? I think there is a risk there will be other directories inside the data_dir? nosync for example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants