-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aviti FCs to bioinfo tab #441
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #441 +/- ##
==========================================
- Coverage 29.05% 28.86% -0.20%
==========================================
Files 31 31
Lines 4898 4941 +43
==========================================
+ Hits 1423 1426 +3
- Misses 3475 3515 +40 ☔ View full report in Codecov by Sentry. |
Not familiar with this part of TACA, but the changes look reasonable to me. Request versionlog update. |
Will do when it's ready to merge, so that the dates are right. |
logger.info(f"Working on {run_dir}") | ||
update_statusdb(run_dir, inst_brand) | ||
elif inst_brand == "element": | ||
logger.info(f"Working on {run_dir}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to have some kind of regular expression to check for a rundir here as well? I think there is a risk there will be other directories inside the data_dir? nosync for example?
For reference https://genomics-status-stage.scilifelab.se/bioinfo/P32102