Skip to content

Restructure tests and CI to the SciML grouped layout - #3

Merged
xtalax merged 1 commit into
masterfrom
forge/test-structure
Oct 28, 2026
Merged

xtalax merged 1 commit into
masterfrom
forge/test-structure

Conversation

@xtalax-droid

Copy link
Copy Markdown
Collaborator

Aligns the test layout and CI with MethodOfLines.jl's SciML grouped testing.

  • test/runtests.jl is unchanged. run_tests() selects the group from GROUP by folder discovery. Core is the top-level test/*.jl files, so the existing load test stays there. QA is test/qa/.
  • The QA group now runs Aqua and JET. JET is added to test/qa/Project.toml, and the SciMLTesting compat there is raised to 2.8.
  • test/shared/ is added for helpers shared between groups. It is not a declared group, so it is never auto-discovered.
  • test/README.md documents running a group, adding a group (a directory plus a one-line test_groups.toml entry), the planned milestone groups, how coverage is collected, and the rule that every code path needs an end-to-end test (PDESystem, discretize, solve, exact or manufactured solution, or MOL).
  • Tests.yml fans out per group from test_groups.toml via the reusable workflow, and now also covers release- branches and ignores docs/** changes.

Tests: GROUP=Core passes (1 test) and GROUP=QA passes (21 tests). There are no src changes. Codex approved with one minor finding: the release- branch filter is a literal match, as in MethodOfLines' Tests.yml.

Open points for review: confirm test/qa/qa.jl really exercises JET (installation and a passing group are verified, JET testsets are not), and that coverage and Codecov upload happen inside the reusable grouped-tests.yml.


🤖 Posted by an AI agent · harness: Claude Code 2.1.310 · model: claude-sonnet-5-5
Review: unreviewed
Session: 43e03fde-3384-4386-bae9-03e81f19ba7c

Adds JET to the QA group, test/shared for helpers, a README documenting how to add groups and the end-to-end coverage rule, and docs-path filtering in Tests.yml as in MethodOfLines.jl.

Agent-Harness: Claude Code 2.1.310
Agent-Model: claude-sonnet-5-5
Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c
Agent-Review: unreviewed
Co-authored-by: Claude Code <agent@noreply.juliahub.com>
@xtalax
xtalax merged commit 37d5219 into master Oct 28, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants