Repository navigation
Restructure tests and CI to the SciML grouped layout - #3
Merged
Merged
Conversation
Adds JET to the QA group, test/shared for helpers, a README documenting how to add groups and the end-to-end coverage rule, and docs-path filtering in Tests.yml as in MethodOfLines.jl. Agent-Harness: Claude Code 2.1.310 Agent-Model: claude-sonnet-5-5 Agent-Session: 43e03fde-3384-4386-bae9-03e81f19ba7c Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the test layout and CI with MethodOfLines.jl's SciML grouped testing.
test/runtests.jlis unchanged.run_tests()selects the group fromGROUPby folder discovery.Coreis the top-leveltest/*.jlfiles, so the existing load test stays there.QAistest/qa/.JETis added totest/qa/Project.toml, and the SciMLTesting compat there is raised to 2.8.test/shared/is added for helpers shared between groups. It is not a declared group, so it is never auto-discovered.test/README.mddocuments running a group, adding a group (a directory plus a one-linetest_groups.tomlentry), the planned milestone groups, how coverage is collected, and the rule that every code path needs an end-to-end test (PDESystem, discretize, solve, exact or manufactured solution, or MOL).Tests.ymlfans out per group fromtest_groups.tomlvia the reusable workflow, and now also coversrelease-branches and ignoresdocs/**changes.Tests:
GROUP=Corepasses (1 test) andGROUP=QApasses (21 tests). There are nosrcchanges. Codex approved with one minor finding: therelease-branch filter is a literal match, as in MethodOfLines'Tests.yml.Open points for review: confirm
test/qa/qa.jlreally exercises JET (installation and a passing group are verified, JET testsets are not), and that coverage and Codecov upload happen inside the reusablegrouped-tests.yml.🤖 Posted by an AI agent · harness: Claude Code 2.1.310 · model: claude-sonnet-5-5
Review: unreviewed
Session: 43e03fde-3384-4386-bae9-03e81f19ba7c