Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Training Strategies to dae_solvers.jl #838

Closed
wants to merge 28 commits into from

Conversation

hippyhippohops
Copy link

Added in StochasticTraining strategy for generate_loss function

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Added in StochasticTraining strategy for generate_loss function
@hippyhippohops hippyhippohops changed the title Update dae_solve.jl: Added in StochasticTraining strategy Adding Training Strategies to dae_solvers.jl Mar 26, 2024
Added WeightedIntervalTraining
src/dae_solve.jl Outdated Show resolved Hide resolved
src/dae_solve.jl Outdated Show resolved Hide resolved
Copy link
Author

@hippyhippohops hippyhippohops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have refactoed the generate_loss function for ode_solve. I just merged all the functions into one main function and added the conditional statements to carry out the different tasks based on the abstract type of the strategy.

@sathvikbhagavan
Copy link
Member

No, that was not the issue. The issue was to refactor common computations in generate_loss in ODEs and DAEs into common functions such that we don't repeat ourselves.

Copy link
Author

@hippyhippohops hippyhippohops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the WeightedIntervalTraining Strategy in dae_solve.jl and the relevant test in NNDAE_test.jl, which the strategy passes. I would like to push that to be merged. My code has been formatted using JuliaFormatter too.

@sathvikbhagavan
Copy link
Member

I think we should add rest of the strategies before merging.

@sathvikbhagavan
Copy link
Member

Closing this in favour of #876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants