Further testing clean up to get CI green #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vaibhavdixit02
changed the title
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
===========================================
- Coverage 82.65% 71.67% -10.99%
===========================================
Files 8 8
Lines 173 173
===========================================
- Hits 143 124 -19
- Misses 30 49 +19
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Vaibhavdixit02
changed the title
|
I had to comment out NonconvexMultistart because of STOR-i/GaussianProcesses.jl#204 (comment), once we get a new release of that we can retry |
|
There are a couple of other issues happening with Nonconvex so I think we should disable it in this PR for now and move forward with it. We should follow up, with @mohamed82008's help, from a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.