Adding ETD2RK4 exponential integrator algorithm #1661
+110
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 6, 2022 17:18
|
Rename PR to reflect contribution? |
Done! Thanks for the suggestion :-) |
YingboMa
reviewed
May 12, 2022
|
|
||
| if integrator.iter == 1 | ||
| # Initialize the first step using Dorm-Prince-5 (also 4th-order) | ||
| aij = [ |
There was a problem hiding this comment.
We normally write the tableau in https://github.com/SciML/OrdinaryDiffEq.jl/blob/master/src/tableaus/low_order_rk_tableaus.jl so it is only initialized once.
There was a problem hiding this comment.
Hi @YingboMa , sorry for the slow reply. So, I should use one of the tableaus for Dorm-Prince-5 that is already in that file for the first-step initialization? Ok, I will try to make that change and resubmit over the next few days.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development to add a new exponential integrator, ETD2RK4 from Krogstad's 2005 paper. Krylov/non-krylov OOP versions are implemented and seem to be working (although tests are throwing an error). IIP versions still need to be added. First step is calculated using DP5 (which is also 4th-order).