Don't setup a JacVec if concrete_jac==true, and use non SciMLOperator W_prototype
#2491
+8
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
changed the title
JacVec if concrete=jac==true, and use non SciMLOperator W_prototype
oscardssmith
changed the title
JacVec if concrete=jac==true, and use non SciMLOperator W_prototypeJacVec if concrete_jac==true, and use non SciMLOperator W_prototype
| jacvec = JacVec(__f, copy(u), p, t; | ||
| autodiff = alg_autodiff(alg), tag = OrdinaryDiffEqTag()) | ||
| WOperator{IIP}(f.mass_matrix, dt, J, u, jacvec) | ||
| WOperator{IIP}(f.mass_matrix, dt, J, u, nothing) |
There was a problem hiding this comment.
by using the Jacobian. if you scroll up to the w_operator ops, they all check for whether ja cacvec exists
| @@ -391,7 +391,7 @@ function do_newJW(integrator, alg, nlsolver, repeat_step)::NTuple{2, Bool} | |||
| # TODO: add `isJcurrent` support for Rosenbrock solvers | |||
| if !isnewton(nlsolver) | |||
| isfreshJ = !(integrator.alg isa CompositeAlgorithm) && | |||
| (integrator.iter > 1 && errorfail && !integrator.u_modified) | |||
There was a problem hiding this comment.
how would this not be an issue to drop?
There was a problem hiding this comment.
if iter<=1 we already returned on the first line (I changed that a few months ago)
|
Rebase? |
oscardssmith
force-pushed
the
os/no-jacvec-if-concrete_jac
branch
from
6a2cb4d to
01b0c61
Compare
oscardssmith
force-pushed
the
os/no-jacvec-if-concrete_jac
branch
from
01b0c61 to
851e3aa
Compare
|
rebased now that CI ismore stable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is a good idea yet, but I want to run it past CI.