Fix ND problems stack overflow in Enright-Pryce benchmarks #1359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The ND problems (orbital mechanics/Kepler orbit benchmarks) were causing stack overflow errors during compilation. The root cause was the complex symbolic expression:
When used in the gravitational force equations
(-y[1]) / r
and(-y[2]) / r
, this created overly complex symbolic manipulations that caused ModelingToolkit's symbolic engine to exceed stack limits during compilation.Solution
Replaced the complex expression with mathematically equivalent intermediate variables:
This represents the same physics (gravitational force law
F ∝ 1/r³
) but breaks down the symbolic computation into manageable steps.Test Plan
The fix specifically addresses the compilation issue reported in the Enright-Pryce benchmarks documentation where all ND problems showed "StackOverflowError".
🤖 Generated with Claude Code