Update NonStiffODE benchmarks for ModelingToolkit v10 compatibility #1361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
Project Dependencies
benchmarks/NonStiffODE/Project.toml
to allowModelingToolkit = "9, 10"
Code Updates
using IfElse
from enright_pryce.jl (line 2)ODESystem(eqs, t, name=...)
complete
for finalizationBase.ifelse
through themyifelse
function@parameters
ModelingToolkit v10 Compatibility
The NonStiffODE benchmarks were already following best practices compatible with MTK v10:
t
complete(let ... end)
for proper finalizationBase.ifelse
through a localmyifelse
function, which works in both v9 and v10@parameters
Testing
Impact
This change enables:
The Enright-Pryce benchmark suite (88 test problems across stiff and non-stiff categories) can now utilize the latest ModelingToolkit improvements while preserving all existing functionality.
🤖 Generated with Claude Code